[Kimchi-devel] [PATCH V3 0/4] Authorization: disable non-root user functions in UI

[Aline Manera]

The patch seems good for me.
Just some comments about how the UI looks for a user.







In the storage tab, we should expand the last column just enough to 
display the \/ icon

| ISO               63% |  *  | /var/lib/kimchi/isos | 
dir                    | 49.1G           | 
31.2G                                      | \/ |


In the network tab, there is a tiny white line in the last column where 
it would be the actions menu


On 07/22/2014 06:51 AM, wenwang at linux.vnet.ibm.com wrote:
> From: Wen Wang <wenwang at linux.vnet.ibm.com>
>
> V2 -> V3:
> stored the mode into global _tabMode that can be used for each tab.(Aline)
> Making the buttons that is not avaiable for non-root users invisible
> by default and enable when user is admin.(Yu Xin)
> Fixed css inconsistent under "Storage" tab.
> Removed the onClick function if the buttons are not avaiable.
>
> V1 -> V2:
> Store "roles" parameter in cookie instead of each tab's mode.(Aline)
> read only "roles" from cookie instead of roles of each tab(Aline)
> Minor changes in method of removing "Action" title under network tab
> (Hongliang Wang)
>
> This patch defines user privilege according to different user roles In this
> release, only two roles are supported: "admin" and "user", conbined with four
> modes: "admin", "byInstance", "read-only" and "none", each of which has own
> privileges to different tabs as well as instances. modes are stored in cookie
> and functions of different roles are protected in the back-end.
>
> Wen Wang (4):
>    Add roles into cookie
>    Authorization: remove host/template tabs for non-root users
>    Authorization: remove [+] icon from non-root users view
>    Authorization: Remove actions based on roles
>
>   ui/css/theme-default/storage.css  |   22 ++++---
>   ui/js/src/kimchi.guest_main.js    |   10 ++-
>   ui/js/src/kimchi.login.js         |   16 +++--
>   ui/js/src/kimchi.main.js          |   26 +++++--
>   ui/js/src/kimchi.network.js       |   10 +++-
>   ui/js/src/kimchi.storage_main.js  |  137 ++++++++++++++++++++-----------------
>   ui/js/src/kimchi.template_main.js |   21 ++++--
>   ui/pages/tabs/guests.html.tmpl    |    4 +-
>   ui/pages/tabs/network.html.tmpl   |    6 +-
>   ui/pages/tabs/storage.html.tmpl   |    6 +-
>   ui/pages/tabs/templates.html.tmpl |    2 +-
>   11 files changed, 153 insertions(+), 107 deletions(-)
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140722/3b6e94ff/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcchhbbi.
Type: image/jpeg
Size: 12006 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140722/3b6e94ff/attachment.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cdhdhhdd.
Type: image/jpeg
Size: 11997 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140722/3b6e94ff/attachment-0001.jpe>