[Kimchi-devel] [PATCH] Fix pep8 errors in make check

Aline Manera alinefm at linux.vnet.ibm.com
Wed Jul 30 19:14:54 UTC 2014


I think you meant pyflakes instead of pep8 =)

On 07/28/2014 12:39 AM, lvroyce at linux.vnet.ibm.com wrote:
> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>
> Fix 2 pep8 errors in make check
>
> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
> ---
>   src/kimchi/control/base.py | 4 +---
>   src/kimchi/root.py         | 1 -
>   2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/src/kimchi/control/base.py b/src/kimchi/control/base.py
> index ac24b3f..4d1351f 100644
> --- a/src/kimchi/control/base.py
> +++ b/src/kimchi/control/base.py
> @@ -65,9 +65,7 @@ class Resource(object):
>
>       def generate_action_handler(self, action_name, action_args=None):
>           def wrapper(*args, **kwargs):
> -            method = validate_method(('POST'),
> -                                     self.role_key, self.admin_methods)
> -
> +            validate_method(('POST'), self.role_key, self.admin_methods)
>               try:
>                   self.lookup()
>                   if not self.is_authorized():
> diff --git a/src/kimchi/root.py b/src/kimchi/root.py
> index dec5862..1bae7be 100644
> --- a/src/kimchi/root.py
> +++ b/src/kimchi/root.py
> @@ -17,7 +17,6 @@
>   # License along with this library; if not, write to the Free Software
>   # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
>
> -import base64
>   import cherrypy
>   import json
>   import os




More information about the Kimchi-devel mailing list