[Kimchi-devel] [PATCH v3 0/4] Fix: Report Overwritten when Provided Name Existing

Hongliang Wang hlwang at linux.vnet.ibm.com
Sat Jun 14 13:24:01 UTC 2014


On 06/13/2014 08:21 PM, Aline Manera wrote:
>
> When I entered an existent debug report name, the screen blinks to 
> display the error message
> Is there a way to fix it?
So you mean it's too short to see the whole message before it 
disappears? It's really a problem for long messages. Let me send another 
patch to make the time length configurable.
>
> On 06/13/2014 06:16 AM, Hongliang Wang wrote:
>> When user provides an existing debug report name, then the server 
>> will generate
>> a new debug report and overwrite the old one.
>>    Fixed it in this patch to detect the existing name and ask the 
>> user to choose
>> another name.
>>
>> v2 -> v3:
>>    3a) Reduced code redundant
>>        (Wen Wang's comment)
>>
>> v1 -> v2:
>>    2a) Recovered Generate Button behavior
>>        (Wen Wang's comment)
>>    2b) Leveraged get_list() function to check name existence
>>        (Aline's comment)
>>
>> Hongliang Wang (4):
>>    Add ResourceAlreadyExists Exception (HTTP 409)
>>    Add Name Existence Check for Debug Report when Create
>>    Add License Statement in kimchi.report_add_main.js
>>    Implement UI Part to Properly Handle Report Name Existence
>>
>>   src/kimchi/control/base.py          |  4 +-
>>   src/kimchi/exception.py             |  4 ++
>>   src/kimchi/i18n.py                  |  1 +
>>   src/kimchi/model/debugreports.py    |  5 +-
>>   ui/js/src/kimchi.report_add_main.js | 97 
>> +++++++++++++++++++++++--------------
>>   5 files changed, 73 insertions(+), 38 deletions(-)
>>
>




More information about the Kimchi-devel mailing list