[Kimchi-devel] [PATCHv2 3/3] Add doc and test case for dedicate iso pool

[Aline Manera]

On 06/12/2014 05:03 AM, lvroyce at linux.vnet.ibm.com wrote:
> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>
> Add doc for user to upload the iso to a dedicate pool,
> add testcase to validate correctness.
>
> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
> ---
>   docs/README.md      | 5 +++++
>   tests/test_model.py | 3 +++
>   2 files changed, 8 insertions(+)
>
> diff --git a/docs/README.md b/docs/README.md
> index c658637..2591f7c 100644
> --- a/docs/README.md
> +++ b/docs/README.md
> @@ -143,6 +143,11 @@ The template screen looks like:
>   From this view, you can change the parameters of a template or create a
>   new template using the "+" button in the upper right corner.
>
> +To create a template, you need an ISO on your host or using remote one.
> +If you are willing to use your own ISO,
> +please copy it to out of box storage pool (default path is:
> +/var/lib/libvirt/isos).
> +

Royce, add it to the help page as well.
ui/pages/help/*/storage.dita


>   Known Issues
>   ------------
>
> diff --git a/tests/test_model.py b/tests/test_model.py
> index 142e4fc..ea38f59 100644
> --- a/tests/test_model.py
> +++ b/tests/test_model.py
> @@ -416,6 +416,9 @@ class ModelTests(unittest.TestCase):
>           self.assertIn('default', pools)
>           poolinfo = inst.storagepool_lookup('default')
>           self.assertEquals('active', poolinfo['state'])
> +        self.assertIn('ISO', pools)
> +        poolinfo = inst.storagepool_lookup('ISO')
> +        self.assertEquals('active', poolinfo['state'])
>           self.assertEquals((num - 1), len(pools))
>
>       @unittest.skipUnless(utils.running_as_root(), 'Must be run as root')