[Kimchi-devel] [PATCH v4 0/8] Debug Report Rename Feature

[Aline Manera]

Thanks for the patches, Hongliang!
And congratulations for the backend ones! It is a big accomplishment!

I don't have any comments about the patches themselves.

You only forgot to add code for mockmodel.py
And also add tests to ensure this feature will work in future and avoid 
regression

On 06/17/2014 05:58 AM, Hongliang Wang wrote:
> Enable debug report rename feature in this patch set.
>
>    Please apply the following patch set first:
>    * [PATCH v4 0/4] Fix: Report Overwritten when Provided Name Existing
>
> v3 -> v4:
>    4a) Updated according to dependency changes
>
> v2 -> v3:
>    3a) Added check for name existence when renaming a report
>        (Yu Xin's comment)
>
> v1 -> v2:
>    2a) Retrieved the Right Generated Time for Debug Report
>        (Wen Wang's comment)
>    2b) Sorted debug reports by Generated Time Descendingly
>        (Wen Wang's comment)
>    2c) Enabled Form Fields after Request Processed
>        (Yuxin's comment)
>
> Hongliang Wang (8):
>    Debug Report Rename: Update API.json
>    Debug Report Rename: Update API.md
>    Debug Report Rename: Implement Back-end
>    Debug Report: Use Generated Time instead of Most Changed Time
>    Debug Report: Sort Reports by Generated Time Descendingly
>    Debug Report Rename UI: Add API in kimchi.api.js
>    Debug Report Rename UI: Add Rename Page
>    Debug Report Rename UI: Enable Rename in Host Tab
>
>   docs/API.md                            |  3 ++
>   src/kimchi/API.json                    | 11 +++++++
>   src/kimchi/control/debugreports.py     |  8 ++++-
>   src/kimchi/model/debugreports.py       | 18 +++++++++++-
>   ui/css/theme-default/report-rename.css | 22 ++++++++++++++
>   ui/js/src/kimchi.api.js                | 12 ++++++++
>   ui/js/src/kimchi.host.js               | 35 +++++++++++++++-------
>   ui/js/src/kimchi.report_rename_main.js | 41 ++++++++++++++++++++++++++
>   ui/pages/report-rename.html.tmpl       | 53 ++++++++++++++++++++++++++++++++++
>   9 files changed, 190 insertions(+), 13 deletions(-)
>   create mode 100644 ui/css/theme-default/report-rename.css
>   create mode 100644 ui/js/src/kimchi.report_rename_main.js
>   create mode 100644 ui/pages/report-rename.html.tmpl
>