[Kimchi-devel] [PATCHv4 0/4] Add volume reference count

[Aline Manera]

The tests are failing with this patch set:

======================================================================
ERROR: test_template_storage_customise (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/home/alinefm/kimchi/tests/test_model.py", line 407, in 
test_template_storage_customise
     volinfo = inst.storagevolume_lookup(pool, vol)
   File "/home/alinefm/kimchi/src/kimchi/model/storagevolumes.py", line 
139, in lookup
     ref_cnt = self._get_ref_cnt(pool, name, path)
   File "/home/alinefm/kimchi/src/kimchi/model/storagevolumes.py", line 
127, in _get_ref_cnt
     if path == VMStorageModel(**args).lookup(vm, disk)['path']:
   File "/home/alinefm/kimchi/src/kimchi/model/vmstorages.py", line 166, 
in lookup
     source = disk.source
   File "lxml.objectify.pyx", line 226, in 
lxml.objectify.ObjectifiedElement.__getattr__ 
(src/lxml/lxml.objectify.c:2894)
   File "lxml.objectify.pyx", line 485, in 
lxml.objectify._lookupChildOrRaise (src/lxml/lxml.objectify.c:5428)
AttributeError: no such child: source

----------------------------------------------------------------------
Ran 157 tests in 136.021s

FAILED (errors=1)
make[3]: *** [check-local] Error 1
make[3]: Leaving directory `/home/alinefm/kimchi/tests'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/alinefm/kimchi/tests'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/alinefm/kimchi/tests'
make: *** [check-recursive] Error 1


On 02/27/2014 06:48 AM, lvroyce at linux.vnet.ibm.com wrote:
> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>
> Available volumes will be tracked by volume reference count.
> Add this field to storage volume,
> so that storage volume/pool action validation can rely on it.
>
> Royce Lv (4):
>    Add volume ref_cnt: update api.md
>    Add volume ref_cnt: Update controller and json schema
>    Add volume ref_cnt: Add model and mockmodel implementation
>    Add volume ref_cnt: Update test
>
>   docs/API.md                          |  3 +++
>   src/kimchi/API.json                  | 25 +++++++++++++++++++++++++
>   src/kimchi/control/storagevolumes.py |  1 +
>   src/kimchi/i18n.py                   |  4 ++++
>   src/kimchi/mockmodel.py              |  3 +++
>   src/kimchi/model/storagevolumes.py   | 31 +++++++++++++++++++++++++++++++
>   tests/test_model.py                  |  4 ++++
>   tests/test_rest.py                   |  2 ++
>   8 files changed, 73 insertions(+)
>