[Kimchi-devel] [PATCHv4 0/4] Add volume reference count

[Royce Lv]

Cristian,

I have run make check every time before submitting patch.

And this bug is fixed by [Kimchi-devel][PATCHv3 1/5] Fix vm disk path 
when it does not have source element.
For cdrom it sometimes doesn't have source.

Because Aline commented why this is needed last time so I splitted these 
two because they are not related.

And as you can see, this bug is not introduced by my patch and is env 
dependent (can not be reproduced on every env).
But nevertherless, I will repost this patchset with the bug fix patch.

On 2014年03月04日 02:28, Crístian Viana wrote:
> Please, run "sudo make check" before submitting patches.
>
> Am 03-03-2014 15:22, schrieb Aline Manera:
>>
>> The tests are failing with this patch set:
>>
>> ======================================================================
>> ERROR: test_template_storage_customise (test_model.ModelTests)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>> File "/home/alinefm/kimchi/tests/test_model.py", line 407, in 
>> test_template_storage_customise
>> volinfo = inst.storagevolume_lookup(pool, vol)
>> File "/home/alinefm/kimchi/src/kimchi/model/storagevolumes.py", line 
>> 139, in lookup
>> ref_cnt = self._get_ref_cnt(pool, name, path)
>> File "/home/alinefm/kimchi/src/kimchi/model/storagevolumes.py", line 
>> 127, in _get_ref_cnt
>> if path == VMStorageModel(**args).lookup(vm, disk)['path']:
>> File "/home/alinefm/kimchi/src/kimchi/model/vmstorages.py", line 166, 
>> in lookup
>> source = disk.source
>> File "lxml.objectify.pyx", line 226, in 
>> lxml.objectify.ObjectifiedElement.__getattr__ 
>> (src/lxml/lxml.objectify.c:2894)
>> File "lxml.objectify.pyx", line 485, in 
>> lxml.objectify._lookupChildOrRaise (src/lxml/lxml.objectify.c:5428)
>> AttributeError: no such child: source
>>
>> ----------------------------------------------------------------------
>> Ran 157 tests in 136.021s
>>
>> FAILED (errors=1)
>> make[3]: *** [check-local] Error 1
>> make[3]: Leaving directory `/home/alinefm/kimchi/tests'
>> make[2]: *** [check-am] Error 2
>> make[2]: Leaving directory `/home/alinefm/kimchi/tests'
>> make[1]: *** [check] Error 2
>> make[1]: Leaving directory `/home/alinefm/kimchi/tests'
>> make: *** [check-recursive] Error 1