[Kimchi-devel] [PATCH 1/2] Make vm model to be a singleton

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Tue Mar 4 10:14:36 UTC 2014


From: Royce Lv <lvroyce at linux.vnet.ibm.com>

When refer vm model get_list method, the stats collection task
will run multiple times. Make vms model class a singleton so that
this task just run once.

Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
---
 src/kimchi/model/vms.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/kimchi/model/vms.py b/src/kimchi/model/vms.py
index 3ae2048..449acdb 100644
--- a/src/kimchi/model/vms.py
+++ b/src/kimchi/model/vms.py
@@ -27,6 +27,7 @@ from cherrypy.process.plugins import BackgroundTask
 
 from kimchi import vnc
 from kimchi import xmlutils
+from kimchi.basemodel import Singleton
 from kimchi.exception import InvalidOperation, InvalidParameter
 from kimchi.exception import MissingParameter, NotFoundError, OperationFailed
 from kimchi.model.config import CapabilitiesModel
@@ -52,6 +53,8 @@ stats = {}
 
 
 class VMsModel(object):
+    __metaclass__ = Singleton
+
     def __init__(self, **kargs):
         self.conn = kargs['conn']
         self.objstore = kargs['objstore']
-- 
1.8.1.2




More information about the Kimchi-devel mailing list