[Kimchi-devel] [PATCH v2 0/4] [UI] CDROM Management in a VM

[Adam King]

On 03/04/2014 01:25 PM, Aline Manera wrote:
>
> The UI looks good!
> I'd just suggest to keep the edit window silver instead of white
I agree, the white is a little too contrasting with the rest of the theme..

>
> And I am not able to remove a cdrom

I was able to add and remove them...

> From the log I got:
>
> 127.0.0.1 - - [04/Mar/2014:15:22:19] "GET 
> /?cdrom=%2Fhome%2Falinefm%2Fisos%2FFedora-Live-Desktop-x86_64-19-1.iso&cdrom=%2Fhome%2Falinefm%2Fisos%2FopenSUSE-13.1-GNOME-Live-x86_64.iso&cdrom=%2Fhome%2Falinefm%2Fisos%2FopenSUSE-13.1-GNOME-Live-x86_64.iso 
> HTTP/1.1" 404 1606 "http://localhost:8000/" "Mozilla/5.0 (X11; Ubuntu; 
> Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0"
>
> And on UI
>
>
>         ERROR CODE
>
> 404 Not Found
>
>
>         REASON
>
> Unexpected query string parameters: cdrom
>
>
>         STACK
>
> Traceback (most recent call last):
>    File "/usr/lib/python2.7/dist-packages/cherrypy/_cprequest.py", line 656, in respond
>      response.body = self.handler()
>    File "/usr/lib/python2.7/dist-packages/cherrypy/lib/encoding.py", line 188, in __call__
>      self.body = self.oldhandler(*args, **kwargs)
>    File "/usr/lib/python2.7/dist-packages/cherrypy/_cpdispatch.py", line 40, in __call__
>      raise sys.exc_info()[1]
> HTTPError: (404, 'Unexpected query string parameters: cdrom')
>
> On 03/04/2014 06:01 AM, Hongliang Wang wrote:
>> Allow user to manipulate CDROM(s) in a VM:
>> 1) Attach one or more CDROM(s);
>> 2) Replace a CDROM with another ISO file path;
>> 3) Detach a CDROM from a VM.
>>
>>    Tested on Chrome.
>>
>>    Please apply the following patch first:
>>    * [UI] Window - Correct Footer Height
>>
>> v1 -> v2:
>>    2a) Separate one patch into 4 small ones to make it easier to review
>>        (Thanks to Ramon Medeiros's comment)
>>    2b) Updated API calling to list CDROM
>>        (Thanks to Aline's comment)
>>    2c) Separated VM updating window into 2 parts: general and storage
>>        (Thanks to Aline's comment)
>>    2d) Enhanced UI to allow user trigger replace CDROM window by clicking
>>        ISO file path text box
>>    2e) Changed uneditable fields from readonly to disabled
>>    2f) Removed authors infomation
>>        (Thanks to Aline's comment)
>>
>> Hongliang Wang (4):
>>    [UI] Add CDROM-related APIs
>>    [UI] Add i18n Variables for CDROM-related Function
>>    [UI] Add/Edit CDROM Support
>>    [UI] Attach/Replace/Detach a CDROM to/in/from a VM
>>
>>   ui/css/theme-default/guest-cdrom-add.css      |  62 +++++++++++
>>   ui/css/theme-default/guest-cdrom-edit.css     |  62 +++++++++++
>>   ui/css/theme-default/guest-edit.css           | 108 +++++++++++++++---
>>   ui/images/theme-default/guest-icon-sprite.png | Bin 0 -> 6748 bytes
>>   ui/js/src/kimchi.api.js                       |  74 +++++++++++++
>>   ui/js/src/kimchi.guest_cdrom_add_main.js      |  79 +++++++++++++
>>   ui/js/src/kimchi.guest_cdrom_edit_main.js     |  87 +++++++++++++++
>>   ui/js/src/kimchi.guest_edit_main.js           |  75 ++++++++++++-
>>   ui/pages/guest-cdrom-add.html.tmpl            |  73 ++++++++++++
>>   ui/pages/guest-cdrom-edit.html.tmpl           |  73 ++++++++++++
>>   ui/pages/guest-edit.html.tmpl                 | 153 +++++++++++++++++---------
>>   ui/pages/i18n.html.tmpl                       |   5 +
>>   12 files changed, 778 insertions(+), 73 deletions(-)
>>   create mode 100644 ui/css/theme-default/guest-cdrom-add.css
>>   create mode 100644 ui/css/theme-default/guest-cdrom-edit.css
>>   create mode 100644 ui/images/theme-default/guest-icon-sprite.png
>>   create mode 100644 ui/js/src/kimchi.guest_cdrom_add_main.js
>>   create mode 100644 ui/js/src/kimchi.guest_cdrom_edit_main.js
>>   create mode 100644 ui/pages/guest-cdrom-add.html.tmpl
>>   create mode 100644 ui/pages/guest-cdrom-edit.html.tmpl
>>
>
>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel


-- 
Adam King <rak at linux.vnet.ibm.com>
IBM CSI

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140304/9bec6a72/attachment.html>