[Kimchi-devel] [PATCH v4 0/5] [UI] CDROM Management in a VM

Hongliang Wang hlwang at linux.vnet.ibm.com
Mon Mar 10 09:44:03 UTC 2014


Allow user to manipulate CDROM(s) in a VM:
1) Attach one or more CDROM(s);
2) Replace a CDROM with another ISO file path;
3) Detach a CDROM from a VM.

  Tested on Chrome.

  Please apply the following patch first:
  * [UI] Window Widget Enhancement - Allow onClose Listener

v3 -> v4:
  4a) Re-organized UI layout based on Adam King's slides:
      * Promoted media management for VM as a separate action
      * Restricted to only CDROM replacement for a running VM
  4b) Removed listeners to avoid duplicate functions

v2 -> v3:
  3a) Keep the edit window silver instead of white
      (Aline's comment)
  3b) Added information after CDROM manipulations to avoid confusion
      (Aline & Adam King's comment)

v1 -> v2:
  2a) Separate one patch into 4 small ones to make it easier to review
      (Thanks to Ramon Medeiros's comment)
  2b) Updated API calling to list CDROM
      (Thanks to Aline's comment)
  2c) Separated VM updating window into 2 parts: general and storage
      (Thanks to Aline's comment)
  2d) Enhanced UI to allow user trigger replace CDROM window by clicking
      ISO file path text box
  2e) Changed uneditable fields from readonly to disabled
  2f) Removed authors infomation
      (Thanks to Aline's comment)

Hongliang Wang (5):
  [UI] kimchi.message - Enhancement
  [UI] Add CDROM-related APIs
  [UI] Add i18n Variables for CDROM-related Function
  [UI] Add/Edit CDROM Support
  [UI] Attach/Replace/Detach a CDROM to/in/from a VM

 ui/css/theme-default/guest-cdrom-edit.css     |  62 +++++++++++
 ui/css/theme-default/guest-edit.css           | 144 ++++++++++++++++++++++---
 ui/css/theme-default/guest-media.css          |  42 ++++++++
 ui/css/theme-default/guest-storage-add.css    |  70 ++++++++++++
 ui/images/theme-default/guest-icon-sprite.png | Bin 0 -> 6748 bytes
 ui/js/src/kimchi.api.js                       |  74 +++++++++++++
 ui/js/src/kimchi.guest_cdrom_edit_main.js     |  87 +++++++++++++++
 ui/js/src/kimchi.guest_edit_main.js           | 105 ++++++++++++++++--
 ui/js/src/kimchi.guest_main.js                |  20 +++-
 ui/js/src/kimchi.guest_media_main.js          |  59 ++++++++++
 ui/js/src/kimchi.guest_storage_add.main.js    |  85 +++++++++++++++
 ui/js/src/kimchi.message.js                   |  27 ++---
 ui/pages/guest-cdrom-edit.html.tmpl           |  73 +++++++++++++
 ui/pages/guest-edit.html.tmpl                 | 150 ++++++++++++++++----------
 ui/pages/guest-media.html.tmpl                |  60 +++++++++++
 ui/pages/guest-storage-add.html.tmpl          |  80 ++++++++++++++
 ui/pages/guest.html.tmpl                      |   1 +
 ui/pages/i18n.html.tmpl                       |  11 ++
 18 files changed, 1063 insertions(+), 87 deletions(-)
 create mode 100644 ui/css/theme-default/guest-cdrom-edit.css
 create mode 100644 ui/css/theme-default/guest-media.css
 create mode 100644 ui/css/theme-default/guest-storage-add.css
 create mode 100644 ui/images/theme-default/guest-icon-sprite.png
 create mode 100644 ui/js/src/kimchi.guest_cdrom_edit_main.js
 create mode 100644 ui/js/src/kimchi.guest_media_main.js
 create mode 100644 ui/js/src/kimchi.guest_storage_add.main.js
 create mode 100644 ui/pages/guest-cdrom-edit.html.tmpl
 create mode 100644 ui/pages/guest-media.html.tmpl
 create mode 100644 ui/pages/guest-storage-add.html.tmpl

-- 
1.8.1.4




More information about the Kimchi-devel mailing list