[Kimchi-devel] [PATCH 2/2] Fix feature tests xml

Sheldon shaohef at linux.vnet.ibm.com
Thu Mar 13 12:09:53 UTC 2014


Just a minor comment below

On 03/13/2014 06:47 PM, lvroyce at linux.vnet.ibm.com wrote:
> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>
> Feature test when kimchi starts, cdrom is configured to be ide,
> change it to be scsi to in line with our template configuration.
>
> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
> ---
>   src/kimchi/featuretests.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/kimchi/featuretests.py b/src/kimchi/featuretests.py
> index 045f72b..9b8f04b 100644
> --- a/src/kimchi/featuretests.py
> +++ b/src/kimchi/featuretests.py
> @@ -46,10 +46,10 @@ ISO_STREAM_XML = """
>         <source protocol='%(protocol)s' name='/url/path/to/iso/file'>
>           <host name='host.name' port='1234'/>
>         </source>
> -      <target dev='hdc' bus='ide'/>
> +      <target dev='sr0' bus='scsi'/>
>         <readonly/>
> -      <alias name='ide0-1-0'/>
> -      <address type='drive' controller='0' bus='1' target='0' unit='0'/>
> +      <alias name='scsi0-0-1'/>
Do we need alias?
is alias not added at run time.

> +      <address type='drive' controller='0' bus='0' target='0' unit='1'/>
>       </disk>
>     </devices>
>   </domain>"""


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center




More information about the Kimchi-devel mailing list