[Kimchi-devel] [PATCH] Fix issue 348: NFS pool creation times out

[Mark Wu]

On 03/18/2014 10:55 PM, Christy Perez wrote:
> Adding a 15 second timeout instead of two seconds. This makes kimchi
> more robust in the face of NFS issues such as this one.
>
> Signed-off-by: Christy Perez <christy at linux.vnet.ibm.com>
> ---
>   src/kimchi/model/libvirtstoragepool.py | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/kimchi/model/libvirtstoragepool.py b/src/kimchi/model/libvirtstoragepool.py
> index b8f3d42..35666dc 100644
> --- a/src/kimchi/model/libvirtstoragepool.py
> +++ b/src/kimchi/model/libvirtstoragepool.py
> @@ -91,10 +91,9 @@ class NetfsPoolDef(StoragePoolDef):
>                        export_path, mnt_point]
>           umount_cmd = ["umount", "-f", export_path]
>           mounted = False
> -        # 2 seconds looks like a reasonable time to wait for a refresh
> -        # in the UI and enough time to verify that the NFS server
> -        # is down.
> -        cmd_timeout = 2
> +        # Due to an NFS bug, NFSv4 exports may take 10-15 seconds to mount
> +        # the first time.
Maybe you could add the info of related bug here too,  such as 
"rhbz#1023059". Anyway, 2s seems a little bit strict for nfs mount.
> +        cmd_timeout = 15
>
>           with RollbackContext() as rollback:
>               rollback.prependDefer(os.rmdir, mnt_point)
Reviewed-by: Mark Wu<wudxw at linux.vnet.ibm.com>