[Kimchi-devel] [PATCH v2] Fix issue 348: NFS pool creation times out

[Paulo Ricardo Paz Vital]

-- 
Reviewed-by: Paulo Vital <pvital at linux.vnet.ibm.com>


On Wed, 2014-03-19 at 13:26 -0500, Christy Perez wrote:
> Adding a 15 second timeout instead of two seconds. This makes kimchi
> more robust in the face of NFS issues such as the one described in
> Red Hat Bug 1023059.
> 
> Signed-off-by: Christy Perez <christy at linux.vnet.ibm.com>
> ---
>  src/kimchi/model/libvirtstoragepool.py | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/src/kimchi/model/libvirtstoragepool.py b/src/kimchi/model/libvirtstoragepool.py
> index b8f3d42..47b239b 100644
> --- a/src/kimchi/model/libvirtstoragepool.py
> +++ b/src/kimchi/model/libvirtstoragepool.py
> @@ -91,10 +91,9 @@ class NetfsPoolDef(StoragePoolDef):
>                       export_path, mnt_point]
>          umount_cmd = ["umount", "-f", export_path]
>          mounted = False
> -        # 2 seconds looks like a reasonable time to wait for a refresh
> -        # in the UI and enough time to verify that the NFS server
> -        # is down.
> -        cmd_timeout = 2
> +        # Due to an NFS bug (See Red Hat BZ 1023059), NFSv4 exports may take
> +        # 10-15 seconds to mount the first time.
> +        cmd_timeout = 15
> 
>          with RollbackContext() as rollback:
>              rollback.prependDefer(os.rmdir, mnt_point)