[Kimchi-devel] [PATCH V4 1/4] make pyflakes happly, remove the unused import module
Rodrigo Trujillo
rodrigo.trujillo at linux.vnet.ibm.com
Fri Mar 21 13:14:07 UTC 2014
Reviewed-by: Rodrigo Trujillo <rodrigo.trujillo at linux.vnet.ibm.com>
On 03/20/2014 08:34 PM, shaohef at linux.vnet.ibm.com wrote:
> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>
> remove the unused import module.
> make pyflakes happly before introduce pyflakes.
>
> Signed-off-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
> Signed-off-by: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
> ---
> src/kimchi/control/plugins.py | 2 +-
> src/kimchi/featuretests.py | 2 --
> src/kimchi/mockmodel.py | 2 +-
> src/kimchi/screenshot.py | 1 -
> src/kimchi/template.py | 1 -
> tests/test_server.py | 1 -
> ui/pages/help/gen-index.py | 1 -
> 7 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/src/kimchi/control/plugins.py b/src/kimchi/control/plugins.py
> index 8dc2273..12c621e 100644
> --- a/src/kimchi/control/plugins.py
> +++ b/src/kimchi/control/plugins.py
> @@ -18,7 +18,7 @@
> # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>
> import kimchi.template
> -from kimchi.control.base import Collection, Resource
> +from kimchi.control.base import Collection
> from kimchi.control.utils import get_class_name, model_fn
> from kimchi.control.utils import UrlSubNode
>
> diff --git a/src/kimchi/featuretests.py b/src/kimchi/featuretests.py
> index a6a28fa..07d5676 100644
> --- a/src/kimchi/featuretests.py
> +++ b/src/kimchi/featuretests.py
> @@ -20,7 +20,6 @@
> import cherrypy
> import libvirt
> import lxml.etree as ET
> -import os
> import socket
> import subprocess
> import threading
> @@ -29,7 +28,6 @@ import threading
> from lxml.builder import E
>
>
> -from kimchi import config
> from kimchi.utils import kimchi_log
>
>
> diff --git a/src/kimchi/mockmodel.py b/src/kimchi/mockmodel.py
> index d40f61a..8ff3dbf 100644
> --- a/src/kimchi/mockmodel.py
> +++ b/src/kimchi/mockmodel.py
> @@ -51,7 +51,7 @@ from kimchi.model.utils import get_vm_name
> from kimchi.model.vms import VM_STATIC_UPDATE_PARAMS
> from kimchi.objectstore import ObjectStore
> from kimchi.screenshot import VMScreenshot
> -from kimchi.utils import pool_name_from_uri, run_command
> +from kimchi.utils import pool_name_from_uri
> from kimchi.utils import template_name_from_uri
> from kimchi.vmtemplate import VMTemplate
>
> diff --git a/src/kimchi/screenshot.py b/src/kimchi/screenshot.py
> index 6c8a599..0040d7c 100644
> --- a/src/kimchi/screenshot.py
> +++ b/src/kimchi/screenshot.py
> @@ -20,7 +20,6 @@
>
> import glob
> import os
> -import random
> import signal
> import tempfile
> import time
> diff --git a/src/kimchi/template.py b/src/kimchi/template.py
> index 5707121..9bb2da5 100644
> --- a/src/kimchi/template.py
> +++ b/src/kimchi/template.py
> @@ -20,7 +20,6 @@
> import cherrypy
> import errno
> import json
> -import os
>
>
> from kimchi.config import paths
> diff --git a/tests/test_server.py b/tests/test_server.py
> index d7b93ad..d06e17a 100644
> --- a/tests/test_server.py
> +++ b/tests/test_server.py
> @@ -17,7 +17,6 @@
> # License along with this library; if not, write to the Free Software
> # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>
> -import json
> import os
> import unittest
>
> diff --git a/ui/pages/help/gen-index.py b/ui/pages/help/gen-index.py
> index 56cbf47..cf7c5d7 100755
> --- a/ui/pages/help/gen-index.py
> +++ b/ui/pages/help/gen-index.py
> @@ -18,7 +18,6 @@
> # License along with this library; if not, write to the Free Software
> # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>
> -import glob
> import libxml2
> import sys
>
More information about the Kimchi-devel
mailing list