[Kimchi-devel] [PATCH] Fix build dependency of pep8

[Aline Manera]

On 03/20/2014 12:27 AM, lvroyce at linux.vnet.ibm.com wrote:
> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>
> On fresh installation,
> make check will fail because of lack of pep8 checker.
> Add it to build dependency.

Royce, I understand why you want to add pep8 as a Kimchi dependency but 
it is not.
We do not need pep8 to run or build Kimchi.
It is only used for developers to check code style.

> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
> ---
>   contrib/DEBIAN/control.in     | 1 +
>   contrib/kimchi.spec.fedora.in | 1 +
>   contrib/kimchi.spec.suse.in   | 1 +
>   docs/README.md                | 7 ++++---
>   4 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/contrib/DEBIAN/control.in b/contrib/DEBIAN/control.in
> index c2b2a40..0a730b6 100644
> --- a/contrib/DEBIAN/control.in
> +++ b/contrib/DEBIAN/control.in
> @@ -24,6 +24,7 @@ Depends: python-cherrypy3 (>= 3.2.0),
>            open-iscsi,
>            firewalld
>   Build-Depends: libxslt,
> +               pep8,
>                  python-libxml2
>   Maintainer: Aline Manera <alinefm at br.ibm.com>
>   Description: Kimchi web server
> diff --git a/contrib/kimchi.spec.fedora.in b/contrib/kimchi.spec.fedora.in
> index bf80104..18bd369 100644
> --- a/contrib/kimchi.spec.fedora.in
> +++ b/contrib/kimchi.spec.fedora.in
> @@ -31,6 +31,7 @@ Requires:	nfs-utils
>   Requires:	iscsi-initiator-utils
>   BuildRequires:	libxslt
>   BuildRequires:	libxml2-python
> +BuildRequires:	python-pep8
>
>   %if 0%{?rhel} == 6
>   Requires:	python-ordereddict
> diff --git a/contrib/kimchi.spec.suse.in b/contrib/kimchi.spec.suse.in
> index cba0899..efbb876 100644
> --- a/contrib/kimchi.spec.suse.in
> +++ b/contrib/kimchi.spec.suse.in
> @@ -27,6 +27,7 @@ Requires:	nfs-client
>   Requires:	open-iscsi
>   BuildRequires:	libxslt-tools
>   BuildRequires:	python-libxml2
> +BuildRequires:	python-pep8
>
>   %if 0%{?sles_version} == 11
>   Requires:       python-ordereddict
> diff --git a/docs/README.md b/docs/README.md
> index 8b8b181..9875ee1 100644
> --- a/docs/README.md
> +++ b/docs/README.md
> @@ -53,7 +53,8 @@ Install Dependencies
>                           PyPAM m2crypto python-jsonschema rpm-build \
>                           qemu-kvm python-psutil python-ethtool sos \
>                           python-ipaddr python-lxml nfs-utils \
> -                        iscsi-initiator-utils libxslt pyparted
> +                        iscsi-initiator-utils libxslt pyparted \
> +                        python-pep8
>        # If using RHEL6, install the following additional packages:
>        $ sudo yum install python-unittest2 python-ordereddict
>        # Restart libvirt to allow configuration changes to take effect
> @@ -75,7 +76,7 @@ for more information on how to configure your system to access this repository.
>                              python-pam python-m2crypto python-jsonschema \
>                              qemu-kvm libtool python-psutil python-ethtool \
>                              sosreport python-ipaddr python-lxml nfs-common \
> -                           open-iscsi lvm2 xsltproc python-parted
> +                           open-iscsi lvm2 xsltproc python-parted pep8
>
>       Packages version requirement:
>           python-jsonschema >= 1.3.0
> @@ -89,7 +90,7 @@ for more information on how to configure your system to access this repository.
>                             python-pam python-M2Crypto python-jsonschema \
>                             rpm-build kvm python-psutil python-ethtool \
>                             python-ipaddr python-lxml nfs-client open-iscsi \
> -                          libxslt-tools python-xml python-parted
> +                          libxslt-tools python-xml python-parted python-pep8
>
>       Packages version requirement:
>           python-psutil >= 0.6.0