[Kimchi-devel] [PATCH V3 0/3] Fix non persistent network handling

[Aline Manera]

The tests are failing:

127.0.0.1 - - [26/Mar/2014:13:12:47] "GET /networks/test-network 
HTTP/1.1" 200 271 "" ""
[26/Mar/2014:13:12:47] HTTP Traceback (most recent call last):
   File "/usr/lib/python2.7/dist-packages/cherrypy/_cprequest.py", line 
656, in respond
     response.body = self.handler()
   File "/usr/lib/python2.7/dist-packages/cherrypy/lib/encoding.py", 
line 188, in __call__
     self.body = self.oldhandler(*args, **kwargs)
   File "/usr/lib/python2.7/dist-packages/cherrypy/_cpdispatch.py", line 
34, in __call__
     return self.callable(*self.args, **self.kwargs)
   File "/home/alinefm/kimchi/src/kimchi/control/base.py", line 72, in 
wrapper
     ident = fn(*model_args)
   File "/home/alinefm/kimchi/src/kimchi/mockmodel.py", line 629, in 
network_deactivate
     network = _get_network(name)
NameError: global name '_get_network' is not defined

127.0.0.1 - - [26/Mar/2014:13:12:47] "POST 
/networks/test-network/deactivate HTTP/1.1" 500 905 "" ""

======================================================================
FAIL: test_network_action (test_rest.HttpsRestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/home/alinefm/kimchi/tests/test_rest.py", line 1314, in 
test_network_action
     self.assertEquals('inactive', network['state'])
AssertionError: 'inactive' != u'active'

======================================================================
FAIL: test_network_action (test_rest.RestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/home/alinefm/kimchi/tests/test_rest.py", line 1314, in 
test_network_action
     self.assertEquals('inactive', network['state'])
AssertionError: 'inactive' != u'active'

======================================================================




On 03/25/2014 09:32 AM, Rodrigo Trujillo wrote:
> V3:
> Changes mockmodel and tests (Royce suggestion)
>
> V2:
> Address Ming comments:
>     - Updates API.md
>     - remove useless comments and return
>
> V1:
> Kimchi networks have the same problem storage had. Non persistent
> networks are not stop, they are removed by libvirt and this causes
> an error in Kimchi.
>
> Rodrigo Trujillo (3):
>    Fix non persistent network handling (backend)
>    Fix non persistent network handling (frontend)
>    Fix non persistent network handling (mockmodel/tests)
>
>   docs/API.md                    |  2 ++
>   src/kimchi/control/networks.py |  3 ++-
>   src/kimchi/mockmodel.py        |  7 +++++-
>   src/kimchi/model/networks.py   |  3 ++-
>   tests/test_model.py            |  1 +
>   tests/test_rest.py             |  1 +
>   ui/js/src/kimchi.network.js    | 55 ++++++++++++++++++++++++++++--------------
>   ui/pages/i18n.html.tmpl        |  1 +
>   8 files changed, 52 insertions(+), 21 deletions(-)
>