[Kimchi-devel] [PATCH] Issue #317: disable storage pool create by default in UI

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Wed May 14 03:38:20 UTC 2014


From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>

All button status of add/create pages should be consistent - it should
be disabled by default until the minimum of the required fields are
filled.

Signed-off-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
---
 ui/js/src/kimchi.storagepool_add_main.js | 8 ++++++++
 ui/pages/storagepool-add.html.tmpl       | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js
index 86dbe7f..7bed152 100644
--- a/ui/js/src/kimchi.storagepool_add_main.js
+++ b/ui/js/src/kimchi.storagepool_add_main.js
@@ -145,6 +145,14 @@ kimchi.initStorageAddPage = function() {
     $('#iscsiportId').keyup(function(event) {
         $(this).toggleClass("invalid-field",!/^[0-9]+$/.test($(this).val()));
     });
+    $('#form-pool-add').change(function() {
+        if (kimchi.validateForm()) {
+            $('#pool-doAdd').removeAttr('disabled');
+        } else {
+            $('#pool-doAdd').attr('disabled', 'disabled');
+        }
+
+    });
 };
 
 kimchi.validateForm = function() {
diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl
index 977db66..7406bab 100644
--- a/ui/pages/storagepool-add.html.tmpl
+++ b/ui/pages/storagepool-add.html.tmpl
@@ -152,7 +152,7 @@
         </div>
         <footer>
             <div class="btn-group">
-                <button id="pool-doAdd" class="btn-normal">
+                <button id="pool-doAdd" class="btn-normal" disabled="disabled">
                     <span class="text">$_("Create")</span>
                 </button>
             </div>
-- 
1.9.0




More information about the Kimchi-devel mailing list