[Kimchi-devel] [PATCH] Don't fail if no translation can be found

[Cedric Bosdonnat]

Hi Aline,

On Mon, 2014-11-17 at 15:53 -0200, Aline Manera wrote:
> On 11/17/2014 06:04 AM, Cedric Bosdonnat wrote:
> > Hi Aline,
> >
> > On Fri, 2014-11-14 at 16:12 -0200, Aline Manera wrote:
> >> Hmm...if Kimchi does not recognize a language it falls back to English
> >> (en_US).
> >> So you shouldn't have problems with it.
> >> Could you explain what is the real problem and how I could reproduce it?
> > I got the problem by setting up a kimchi instance as done by this
> > package (minus the patched I sent)
> >
> > https://build.opensuse.org/package/show/home:cbosdonnat/kimchi
> >
> > Connecting with a en_GB client. I got the following exception in the
> > logs:
> >
> > [14/Nov/2014:06:00:06] HTTP Traceback (most recent call last):
> >    File "/usr/lib/python2.7/site-packages/cherrypy/_cprequest.py", line 670, in respond
> >      response.body = self.handler()
> >    File "/usr/lib/python2.7/site-packages/cherrypy/lib/encoding.py", line 212, in __call__
> >      self.body = self.oldhandler(*args, **kwargs)
> >    File "/usr/lib/python2.7/site-packages/cherrypy/_cpdispatch.py", line 61, in __call__
> >      return self.callable(*self.args, **self.kwargs)
> >    File "/usr/lib/python2.7/site-packages/kimchi/root.py", line 92, in default
> >      return template.render(page, kwargs)
> >    File "/usr/lib/python2.7/site-packages/kimchi/template.py", line 109, in render
> >      return render_cheetah_file(resource, data)
> >    File "/usr/lib/python2.7/site-packages/kimchi/template.py", line 95, in render_cheetah_file
> >      return Template(file=filename, searchList=params).respond()
> >    File "_usr_share_kimchi_ui_pages_login_html_tmpl.py", line 107, in respond
> >    File "/usr/lib64/python2.7/gettext.py", line 475, in translation
> >      raise IOError(ENOENT, 'No translation file found for domain', domain)
> > IOError: [Errno 2] No translation file found for domain: 'kimchi'
> 
> Weird! I've just generated a package on openSUSE 13.1 from source code:
> 
> 1) git clone https://github.com/kimchi-project/kimchi.git
> 2) Install all the dependencies

FYI, all deps have been gathered in this OBS project:
https://build.opensuse.org/project/show/home:cbosdonnat

> 3) sudo ./autogen.sh --with-spice-html5 && sudo make && sudo make rpm
> 4) Start kimchid service: sudo service kimchid start
> 5) Access Kimchi on a Firefox 33 which has just one language set: Arabic 
> [ar]
> 6) Kimchi loads in English without any error.
> 
> Could you provide me a package where the error happens? And how did you 
> generate it?


Here is a test rpm I build without the patch:
http://bosdonnat.fr/dl/kimchi-1.3.0-1.3.0.noarch.rpm

This is generated using the Open Build Service
(http://build.opensuse.org), and the osc command.

--
Cedric