[Kimchi-devel] [PATCH] UI: Guest Snapshot

Tue Nov 18 11:17:19 UTC 2014

On 11/18/2014 4:04 AM, Crístian Viana wrote:
> Here are my comments on this patch:
>
> - When I open the dialog "Edit" on a VM without snapshots, the error 
> KCHSNAP0007E* is shown. That's because the VM doesn't have snapshots 
> but the UI should handle that and do nothing. Not having snapshots is 
> not an error from the UI perspective.
Let us discuss why it returns a 404, anyway, the uri has nothing wrong, 
to me, 404 means I am requesting a wrong thing.

why sometimes it returns 500.

>
> - I cannot create a snapshot at all. Whenever I click on the button 
> '+', the error "KCHAPI0006E: Unable to parse JSON request" is shown.
Can you make the backend code more robust, I have to submit an empty 
json below. If submit nothing, then error above.
>
> - I cannot revert to the current snapshot. The button "Revert" becomes 
> disabled whenever the current snapshot is selected. And that's a very 
> important use case. Suppose I just created a snapshot. Then I 
> mistakenly removed some files on my guest system and I want to revert 
> to that snapshot. With the current UI, I'm not able to do that.
Corrected since it can revert to current snapshot. By this way, radio 
button add no value, so change back to original UI to make revert an 
item level action.
>
> - There's no visual feedback when I click on the button "Revert". When 
> I click on it and the revert operation starts, nothing happens. The 
> user might click on it again thinking that the button wasn't clicked 
> on the first time. Also there's no way to know if the revert operation 
> finished.
>
> - If the user clicks on the button "Revert", closes the dialog "Edit" 
> and reopens it while the revert operation is still happening, the 
> error KCHSNAP0007E* is shown and the tab "Snapshot" is rendered empty, 
> even if there are snapshots to be listed on the VM. The same problem 
> also happens when the user clicks on the button with the trash can, 
> instead of "Revert", and closes the dialog and reopens it while the 
> operation hasn't finished.
Seems like 'Revert', 'Create snapshot', 'delete', 'list snapshots' are 
all exclusive, disable all buttons when any action is ongoing, and only 
list existing snapshots when no snapshot creation is ongoing.
Revert is not a long task, it should response within 5 secs, then user 
should wait there for it to complete, or else make it a long task also.

>
> - Why isn't there a button "Revert" on each snapshot line? The button 
> with the trash can is there, the button "Revert" should also be there. 
> That's an action that applies to only one snapshot at a time, just 
> like delete. Other actions in other tabs, like "Edit", are also shown 
> on the relevant line instead of at the top of the dialog. The button 
> "+" is different, though, because it doesn't act in one entry alone, 
> it acts on the whole set of items. So that makes sense for me to be at 
> the top.
Changed it back as it can revert back to current snapshot and radio 
button has no value here.
>
> * Actually, the backend is raising the exception code KCHSNAP007E 
> (i.e. there's one '0' less), which is an invalid code. I'll send a 
> patch later to fix that. But the UI shouldn't worry about that because 
> the REST command returns the status code 404 in that case anyway.
Please correct all those 500 error above and below

>
> On 17-11-2014 09:12, huoyuxin at linux.vnet.ibm.com wrote:
>> From: Yu Xin Huo<huoyuxin at linux.vnet.ibm.com>
>>
>> Signed-off-by: Yu Xin Huo<huoyuxin at linux.vnet.ibm.com>
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jejbdjga.png
Type: image/png
Size: 5146 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: daegcaea.png
Type: image/png
Size: 6341 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhjcabag.png
Type: image/png
Size: 4328 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cbecadic.png
Type: image/png
Size: 2735 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jgjdcffb.png
Type: image/png
Size: 12947 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bhddhibb.png
Type: image/png
Size: 13813 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gbgjahab.png
Type: image/png
Size: 8213 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gijabbdg.png
Type: image/png
Size: 3951 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment-0007.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cjhhbgce.png
Type: image/png
Size: 6595 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141118/aeaf9b97/attachment-0008.png>