[Kimchi-devel] [PATCH V4] Edit Template redefined

[Wen Wang]

That's great. I will remove the filter and have it enabled in V6 patch

On 11/19/2014 1:42 AM, Aline Manera wrote:
>
> Just one comment: I am able to add multiple interfaces pointing to the 
> same network but when I
> open the "Edit Template" dialog in a second moment I can only see one 
> of them
>
> I've just noticed we allow to add multiple interfaces from the same 
> network on a VM, maybe we could change Template do allow the same.
>
> If we follow this approach you need to change the backend to reflect it.
>
> In src/kimchi/API.json remove the line 473:
>
> 469                 "networks": {
> 470                     "description": "list of which networks will be 
> assigned to the new VM.",
> 471                     "type": "array",
> 472                     "items": { "type": "string" },
> 473                     "uniqueItems": true,
> 474                     "error": "KCHTMPL0017E"
> 475                 },
>
> On 11/18/2014 09:06 AM, Wen Wang wrote:
>> From: Wen Wang <wenwang at linux.vnet.ibm.com>
>>
>> V3 -> V4:
>> 1) Deleted "save" icon for storage & interface tab.
>> 2) Fix the bug when submitting multiple network error. Filter the
>> duplicated submission.
>>
>> V2 -> V3:
>> Fix the bug that iscsi and scsi disk size won't change automatically
>>
>> V1 -> V2:
>>
>> 1) Enable "iSCSI" and "SCSI" for storage.
>> 2) Changed the storage tab from "storage" to "Storage".
>> 3) Fix the defect that when editing/adding "Storage" or "Interface" line
>> went down issue.
>> 4) "Storage" and "Interface" content can display properly on Remote and
>> Image created template.
>> 5) Fix the defect that "Image" didn't show properly when using a Image
>> created template.
>>
>> This patch redesigned "Edit Template" diaguage in "Templates". New "Edit
>> Template" will display all the related information into tabs of
>> "General", "Storage" and "Interface". Due to unfinished back-end work,
>> functions are not fully supported, which will be finished in the future
>> work.
>>
>> Temporary disabled functions:
>> 1) Multiple disk operation with multiple storage pools edit in template
>> for which reason the add button in "Storage" tab is disabled.
>> 2) iSCSI and SCSI storage pool add is removed since we are going to
>> allow this kind of operation in the process of creating a VM.
>>
>> Signed-off-by: Wen Wang <wenwang at linux.vnet.ibm.com>
>> ---
>>   ui/css/theme-default/template-edit.css |  116 +++++++++-----
>>   ui/js/src/kimchi.template_edit_main.js |  286 
>> ++++++++++++++++++++-----------
>>   ui/pages/template-edit.html.tmpl       |  158 +++++++++---------
>>   3 files changed, 344 insertions(+), 216 deletions(-)
>>
>