[Kimchi-devel] [PATCHv2 0/2] UI for LDAP support

[Aline Manera]

On 11/24/2014 01:27 PM, Aline Manera wrote:
>
> Some style comments:
>
> 1. Storage, Network and Permission (when ldap) tabs will have a 
> similar layout so all those 3 tabs should share the same margin and 
> alignment values.
>
> Network and Storage differs on margins values.
>
>
>
>
>
>
>
> The Permission tab differs on margin and alignment from the other 2.
> Also the plus icon is over the line.
>
>
>
>
> So I'd suggest to have those margin and alignment values shared in all 
> those 3 tabs.
>
> 2. I think the user input box (when I select the plus icon on 
> Permission tab) should be bigger, like 2x the current width

Also a label for each input box would guide user to which value he/she 
must enter there.
Something like below:

User ID: [_____________________________]
User ID: [_____________________________]
User ID: [_____________________________]

>
>
> On 11/20/2014 08:22 AM, lvroyce at linux.vnet.ibm.com wrote:
>> From: Royce Lv<lvroyce at linux.vnet.ibm.com>
>>
>> v1>v2,
>>      Change according to backend API change.
>>
>> Royce Lv (2):
>>    UI: support ldap vm permission tag
>>    Change guest edit permission logic
>>
>>   ui/css/theme-default/guest-edit.css |  79 +++++++---
>>   ui/js/src/kimchi.api.js             |  15 +-
>>   ui/js/src/kimchi.guest_edit_main.js | 300 ++++++++++++++++++++++++------------
>>   ui/pages/guest-edit.html.tmpl       |  28 +++-
>>   4 files changed, 299 insertions(+), 123 deletions(-)
>>
>
>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141124/97eef79e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 10506 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141124/97eef79e/attachment.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 15987 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141124/97eef79e/attachment-0001.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 11437 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141124/97eef79e/attachment-0002.jpe>