[Kimchi-devel] [PATCH v8 0/3] Backend support for templates with sockets, cores, and threads

[Crístian Viana]

Reviewed-by: Crístian Viana <vianac at linux.vnet.ibm.com>

On 28-10-2014 15:17, Christy Perez wrote:
> v7->v8
> - Add mockmodel tests for POST, PUT and GET
> - Move model test into existing function to work around bug
>      (being worked by Zhou)
>
> v6->v7
> - Add unit tests
> - Rebase
>
> v5->v6:
> - Change cpu_info to empty dict instead of empty string if not specified
> - Split translations into different commit
>
> v4->v5:
> - Fix format issues
> - Remove if check for cpu_info in control, and set cpu_info
>    to the empty string in model if None
> - Add format requirements error for topology requirements.
> - Add new error to toplogy in API.json
> - Update po files
>
> v3->v4:
> - Remove the unused cpu_ elements from common_spec
> - Pass new_t into validate function to reduce complexity
> - Rearrange code to decrese indents in _get_cpu_xml
>
> v2->v3:
> - Set vcpus based on topology, if specified.
> - Move the update cpu+topology validation out to a function
>    for redability
> - Add a minimum value of 1 for topology values
> - Leave new English error msg as empty string
> - Update the API documentation on cpu defaults
>
> v1->v2:
> - Added a check to make sure that vcpus = sockets*cores*threads
> - Set individual topoology params to required in API.json
> - Change the topology object types from string to integer
> - Always return cpu_info from templates lookup()
> - Removed check for cpu_info in to_vm_xml
> - Build cpu_info xml using lxml.builder instead of string
> - CPU and topology verification on template update
>
>
> Christy Perez (3):
>    Backend support for templates with sockets, cores, and threads
>    cpu_info tests for model and mockmodel
>    Translations for new cpu_info messages
>
>   docs/API.md                     | 13 ++++++-
>   po/de_DE.po                     | 76 +++++++++++++++++++++++++++++++++++----
>   po/en_US.po                     | 76 +++++++++++++++++++++++++++++++++++----
>   po/es_ES.po                     | 76 +++++++++++++++++++++++++++++++++++----
>   po/fr_FR.po                     | 76 +++++++++++++++++++++++++++++++++++----
>   po/it_IT.po                     | 76 +++++++++++++++++++++++++++++++++++----
>   po/ja_JP.po                     | 76 +++++++++++++++++++++++++++++++++++----
>   po/kimchi.pot                   | 76 +++++++++++++++++++++++++++++++++++----
>   po/ko_KR.po                     | 76 +++++++++++++++++++++++++++++++++++----
>   po/pt_BR.po                     | 75 ++++++++++++++++++++++++++++++++++----
>   po/ru_RU.po                     | 76 +++++++++++++++++++++++++++++++++++----
>   po/zh_CN.po                     | 79 +++++++++++++++++++++++++++++++++++------
>   po/zh_TW.po                     | 76 +++++++++++++++++++++++++++++++++++----
>   src/kimchi/API.json             | 36 +++++++++++++++++--
>   src/kimchi/control/templates.py | 31 ++++++++--------
>   src/kimchi/i18n.py              |  2 ++
>   src/kimchi/mockmodel.py         |  3 ++
>   src/kimchi/model/templates.py   | 32 +++++++++++++++++
>   src/kimchi/osinfo.py            |  5 ++-
>   src/kimchi/vmtemplate.py        | 15 ++++++++
>   tests/test_mockmodel.py         | 24 +++++++++++++
>   tests/test_model.py             | 13 +++++++
>   22 files changed, 980 insertions(+), 108 deletions(-)
>