[Kimchi-devel] [PATCH] UI bug fix: Properly display storage volumes on Storage tab

Aline Manera alinefm at linux.vnet.ibm.com
Tue Sep 2 18:07:52 UTC 2014


On 09/02/2014 01:48 PM, Crístian Viana wrote:
> On 01-09-2014 15:56, Aline Manera wrote:
>> -        <div class="volumes hide-content">
>> +        <div class="volumes" style="display:none">
> Instead of changing the style directly in the HTML code, I think this 
> patch should edit the class "volumes" in the appropriate CSS file 
> (ui/css/theme-default/storage.css). That file already sets a "display" 
> property, so we're overriding it here, there's no need to do that. And 
> putting styles in CSS files is much easier to maintain and consistent 
> with the rest of the code.

ACK. Please, check V2




More information about the Kimchi-devel mailing list