[Kimchi-devel] [PATCH] issue #454: Properly display storage volumes in a pool with sub-directories

Aline Manera alinefm at linux.vnet.ibm.com
Thu Sep 25 02:50:03 UTC 2014


Kimchi controller allows filterting the resources according to their
parameters, but the filter data type may vary: string, list, regex.

When using re.match() to valid the regex we need to make sure the value
is a string, otherwise we will face the error:

File "/usr/lib64/python2.6/re.py", line 137, in match
   return _compile(pattern, flags).match(string)
File "/usr/lib64/python2.6/re.py", line 232, in _compile
   p = _cache.get(cachekey)
TypeError: unhashable type: 'list'

Signed-off-by: Aline Manera <alinefm at linux.vnet.ibm.com>
---
 src/kimchi/control/base.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kimchi/control/base.py b/src/kimchi/control/base.py
index 2e0816f..1eb10bd 100644
--- a/src/kimchi/control/base.py
+++ b/src/kimchi/control/base.py
@@ -277,7 +277,7 @@ class Collection(object):
 
             if all(key in res.data and
                    (res.data[key] == val or res.data[key] in val or
-                    re.match(val, res.data[key]))
+                    re.match(str(val), res.data[key]))
                    for key, val in fields_filter.iteritems()):
                 data.append(res.data)
         return data
-- 
1.9.3




More information about the Kimchi-devel mailing list