[Kimchi-devel] [PATCH 0/7] Make Template defaults configurable

[Crístian Deives]

I tested this patchset on VMs running Fedora, RHEL and Ubuntu, and only 
on RHEL and Ubuntu the tests haven't finished. As soon as they start, I 
get the following error message:

libvirt:  error : internal error: Network is already in use by interface 
ens3
Fatal: Unable to activate network <libvirt.virNetwork object at 
0x2146290>. Please, check the configuration in                      
/etc/kimchi/template.conf to ensure it lists only 
valid                      networks.
Details: internal error: Network is already in use by interface ens3

As you can see from the error message, there are many unexpected blank 
spaces inside the error string. And I'm afraid the path 
"/etc/kimchi/template.conf" may not always be correct depending on how 
the user is running / has installed Kimchi. For example, I'm running 
Kimchi from the source code, the error message tells me to check 
/etc/kimchi/template.conf but that file doesn't exist here.

On 23-04-2015 16:51, Aline Manera wrote:
> Aline Manera (7):
>    Remove useless variable in osinfo.py
>    Merge common_spec wiht defaults value in osinfo.py
>    Make Template defaults configurable
>    Add libvirt-daemon-config-network package as Kimchi dependency
>    Verify all networks set as Template defaults prior to server start up
>    Create option to auto create ISO pool or not on server start up
>    Verify storage pool set as Template default prior to server starts up
>
>   contrib/DEBIAN/control.in        |   1 +
>   contrib/kimchi.spec.fedora.in    |   3 ++
>   contrib/kimchi.spec.suse.in      |   3 ++
>   docs/README.md                   |  14 +++---
>   src/Makefile.am                  |   2 +-
>   src/kimchi.conf.in               |   3 ++
>   src/kimchi/config.py.in          |   1 +
>   src/kimchi/model/model.py        |  44 +----------------
>   src/kimchi/model/networks.py     |  61 ++++++++++-------------
>   src/kimchi/model/storagepools.py |  66 +++++++++++++++++++++++++
>   src/kimchi/model/templates.py    |   2 -
>   src/kimchi/osinfo.py             | 101 ++++++++++++++++++++++++++++++---------
>   src/kimchid.in                   |   3 ++
>   src/template.conf                |  47 ++++++++++++++++++
>   14 files changed, 240 insertions(+), 111 deletions(-)
>   create mode 100644 src/template.conf
>