[Kimchi-devel] [PATCH 4/5] Implement frontend code to edit MAC address of a guest

[Crístian Deives]

I don't like the JavaScript filter/autocomplete/validation/wizard 
feature here. In my opinion, it gets more in the user's way than helps them:

- There's no indication that the characters ":" will be added automatically.
- I can't type the character ":" (e.g. try typing "AA" and then ":"; the 
character ":" won't be displayed, but it should, because it is the 
expected character there; the user might keep pressing ":" a lot of 
times until they realize that the character will be appended when they 
start typing the rest of the MAC address).
- I can't type most of the useful keyboard combinations I have 
available: Home, End, Ctrl+V, Ctrl+C, Shift+Ctrl+End, etc. This patch 
only allows a small set of keys to be pressed. There's no reason I 
shouldn't type them.
- It's inconsistent with all the other form fields on Kimchi.

A much better approach here would be to let the user type whatever they 
want and validate the input when the user clicks the floppy disk button. 
If something is wrong, a nice message like "you need to enter the MAC 
address in such and such format" can be displayed, just like Kimchi does 
in every form.

On 11-05-2015 14:19, Jose Ricardo Ziviani wrote:
> Signed-off-by: Jose Ricardo Ziviani <joserz at linux.vnet.ibm.com>
> ---
>   ui/js/src/kimchi.guest_edit_main.js | 74 ++++++++++++++++++++++++++++++-------
>   ui/pages/guest-edit.html.tmpl       |  6 ++-
>   2 files changed, 64 insertions(+), 16 deletions(-)