[Kimchi-devel] [PATCH 0/2] Pause/resume support in UI

[Aline Manera]

On 29/05/2015 11:17, Rodrigo Trujillo wrote:
>
> Taking in account  Kimchi simplicity, wouldn't make more sense to hide 
> restart button when VM is offline ? Just a suggestion.

We can open an issue to discuss that as it is not related to this patch 
set and due our time to the 1.5 code freeze.

>
> Rodrigo
>
> On 05/29/2015 10:50 AM, Socorro Stoppler wrote:
>> Hi Cristian,
>>
>> Comment #1:  I'll change it so that the pause/resume button is always 
>> there and just enabled/disabled accordingly.
>> Comment #2:  Thanks for pointing this out and including pictures :-)  
>> I'm using the same icon but need to investigate why it's gettting 
>> shifted.
>>
>> Thanks!
>> -Socorro
>>
>> On 05/28/2015 01:48 PM, Crístian Deives wrote:
>>> Hi Socorro, thanks for this patchset!
>>>
>>> I have two comments about them:
>>>
>>> -  The pause/resume button is invisible when the VM is shutoff and 
>>> it becomes visible when the VM starts. I'd like to see something 
>>> more consistent with the other existing button, "Restart": that 
>>> button is always visible, even when it doesn't make sense to use it 
>>> (i.e. when the VM is shutoff and the button is inactive). When the 
>>> user starts the VM, that button goes from inactive to active. Notice 
>>> how it is always there, enabled or disabled. The pause/resume 
>>> button, however, has a different visibility behavior.
>>>
>>> - When the VM is paused, its icon has a different size and location 
>>> than what it has when the VM is shutoff. When it's paused, the icon 
>>> is bigger, shifted down and out of its external bounds. I'm sending 
>>> two images attached so you can compare them.
>>>
>>> Best regards,
>>> Crístian.
>>>
>>> On 28-05-2015 15:20, Socorro Stoppler wrote:
>>>> From: Socorro Stoppler <socorrob at us.ibm.com>
>>>>
>>>> Add support for pause/resume VM via the UI
>>>>
>>>> Socorro Stoppler (2):
>>>>    First changes for pause/resume UI
>>>>    Add support for Pause/Resume UI
>>>>
>>>>   ui/css/theme-default/button.css              |  20 +++++
>>>>   ui/css/theme-default/list.css                |   6 ++
>>>>   ui/images/theme-default/ac22_pause.png       | Bin 0 -> 1219 bytes
>>>>   ui/images/theme-default/ac22_pause_grey.png  | Bin 0 -> 1175 bytes
>>>>   ui/images/theme-default/ac24_resume.png      | Bin 0 -> 1341 bytes
>>>>   ui/images/theme-default/ac24_resume_grey.png | Bin 0 -> 1282 bytes
>>>>   ui/js/src/kimchi.api.js                      |  23 ++++++
>>>>   ui/js/src/kimchi.guest_main.js               | 114 
>>>> +++++++++++++++++++++++----
>>>>   ui/pages/guest.html.tmpl                     |   4 +
>>>>   9 files changed, 152 insertions(+), 15 deletions(-)
>>>>   create mode 100644 ui/images/theme-default/ac22_pause.png
>>>>   create mode 100644 ui/images/theme-default/ac22_pause_grey.png
>>>>   create mode 100644 ui/images/theme-default/ac24_resume.png
>>>>   create mode 100644 ui/images/theme-default/ac24_resume_grey.png
>>>>
>>>
>>
>> _______________________________________________
>> Kimchi-devel mailing list
>> Kimchi-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel