[Kimchi-devel] [PATCH v2] New Navigation bar

[Aline Manera]

Hi Atreyee,

Only one comment: the second level tab in Kimchi is being displayed a 
different colour per tab.
We should use green for all them. The same you did for Ginger, which 
display all tabs in blue.




On 18/11/2015 04:08, atreyee at linux.vnet.ibm.com wrote:
> From: Atreyee Mukhopadhyay <atreyee at linux.vnet.ibm.com>
>
> This patch is to implement new feature mentioned in issue #746.
> First level navigation bar with Host and Virtualization tabs.
> Second level tab navigation based on first level navigation.
>
> V2 Fixes:
> Review comments from Aline taken care
> 1. alignement of second level navigation with first level navigation
> 2. second level tab color to fit the window
>
> Atreyee Mukhopadhyay (1):
>    Issue #746 : New navigation bar.
>
>   src/wok/plugins/gingerbase/ui/config/tab-ext.xml |  2 +-
>   src/wok/plugins/kimchi/ui/config/tab-ext.xml     |  1 +
>   ui/css/src/modules/_navbar-flat.scss             |  5 +-
>   ui/css/src/modules/_toolbar.scss                 |  9 ++-
>   ui/css/src/modules/_wok-variables.scss           |  9 ++-
>   ui/css/src/wok.scss                              |  4 ++
>   ui/js/src/wok.main.js                            | 87 +++++++++++++++++++++---
>   ui/pages/wok-ui.html.tmpl                        |  8 ++-
>   8 files changed, 105 insertions(+), 20 deletions(-)
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151123/6c7dba53/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cfjjejjh.
Type: image/jpeg
Size: 21577 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151123/6c7dba53/attachment.jpe>