[Kimchi-devel] [PATCH] Proxy websocket connections through nginx

[Paulo Ricardo Paz Vital]

Hey Rob.

Just a little tip: on new master branch, your changes will be related
to Kimchi plugin, located in src/wok/plugins/kimchi directory.

BTW, the patch looks like very nice and I can't wait to test it :-D

Best regards,
Paulo Vital.

On Mon, 2015-10-05 at 18:46 -0300, Aline Manera wrote:
> Hi Rob,
> 
> Could you rebase this patch with the master branch?
> 
> Also with those changes, we can remove the instructions to open the
> port 
> 64667 from the README and src/firewalld.xml files.
> 
> Thanks,
> Aline Manera
> 
> 
> On 05/10/2015 18:07, Rob Lemley wrote:
> > This is a patch against v1.5.1 that sets up nginx to proxy the
> > websocket
> > requests handled by websockify running on port 64667.
> > The changes include modifying the nginx config file
> > (kimchi.conf.in) and
> > various Kimchi files to support the URL changes.
> > Tested on Firefox and Chrome browsers (current versions).
> > 
> > 
> > Rob Lemley (1):
> >    Configure nginx to proxy connections to the websocket server    
> >  so
> >      that browsers don't need to connect to port 64667. This helps 
> >     in
> >      networks with restrictive firewalls.
> > 
> >   src/kimchi/config.py.in              |  8 ++++++++
> >   src/kimchi/model/config.py           |  2 ++
> >   src/kimchi/proxy.py                  |  1 +
> >   src/kimchi/vnc.py                    |  4 ++--
> >   src/kimchid.in                       |  1 +
> >   src/nginx/kimchi.conf.in             | 15 +++++++++++++++
> >   ui/js/src/kimchi.api.js              | 14 +++++++-------
> >   ui/spice-html5/pages/spice_auto.html |  2 +-
> >   8 files changed, 37 insertions(+), 10 deletions(-)
> > 
> 
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>