[Kimchi-devel] [PATCH] Fix opensuse OBS Build Error in the initd file

[Paulo Ricardo Paz Vital]

Hello René

On Wed, 2015-10-14 at 17:06 +0200, René Linder wrote:
> If i understand the Debian/SUSE specs right, it only prevent libvirtd
> from
> stopping as long as kimchi/wok runs.
> 

I just read better some guidelines and checked that "Required-Stop:"
lists the "facilities which must be available during the shutdown of
the service. The init-script system should avoid stopping init scripts
which provide the Required-Stop facilities until this script is
stopped". 

So, I understand it guarantees that libvirtd will be available during
the shutdown process of Wok. It's OK to have this.

Paulo.

> And sorry if it's wrong, first time for me i deal with init.d
> scripts.
> then should the line be completely removed.
> 
> René Linder
> Linder Hard- und Software
> 
> On 14.10.2015 16:25, Paulo Ricardo Paz Vital wrote:
> > Why are you requiring to stop libvirtd when stopping Wok/Kimchi?
> > When
> > stopping Wok or Kimchi and just want to stop this service. The
> > required
> > services can run with no problems.
> > 
> > I can't see a good use case (or business value) to stop libvirt.
> > 
> > Best regards,
> > Paulo
> > 
> > On Wed, 2015-10-14 at 13:14 +0200, LiHaSo wrote:
> > > Signed-off-by: LiHaSo <rene.linder at lihaso.ch>
> > > ---
> > >   contrib/wokd.sysvinit | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/contrib/wokd.sysvinit b/contrib/wokd.sysvinit
> > > index 10680ee..b44ce7c 100644
> > > --- a/contrib/wokd.sysvinit
> > > +++ b/contrib/wokd.sysvinit
> > > @@ -23,7 +23,7 @@
> > >   ### BEGIN INIT INFO
> > >   # Provides: wokd
> > >   # Required-Start: libvirtd
> > > -# Required-Stop:
> > > +# Required-Stop: libvirtd
> > >   # Default-Start: 3 5
> > >   # Default-Stop: 0 1 2 6
> > >   # Description: Start the wokd daemon
>