[Kimchi-devel] Fix for the repository action issue

[Aline Manera]

Please, don't forget to reply to the Kimchi ML

On 15/10/2015 09:43, Samuel Henrique De Oliveira Guimaraes wrote:
>
> Hi Atreye,
>
> Thank you! It works! I’ll rebase my patches and once Aline applies the 
> new-ui in Kimchi master, I’ll be creating an issue for documentation 
> purposes and you can comment that you fixed and send a patch with the 
> issue number to the Mailing List, making your contribution appear in 
> the commit history.
>
> Regards,
>
> Samuel
>
> *From:*Atreye Mukhopadhyay [mailto:atreyee at linux.vnet.ibm.com]
> *Sent:* quinta-feira, 15 de outubro de 2015 09:28
> *To:* Samuel Henrique De Oliveira Guimaraes 
> <samuel.guimaraes at eldorado.org.br>
> *Cc:* Aline Manera <alinefm at linux.vnet.ibm.com>; Chandra Shehkhar 
> Reddy Potula <chandra at linux.vnet.ibm.com>; Walter Niklaus 
> <niklaus at linux.vnet.ibm.com>
> *Subject:* Fix for the repository action issue
>
> Hi Samuel,
> I have fixed the issue you mentioned during the hangout meeting 
> session regarding the incorrect action name for enabled repositories 
> in repository list.
> I worked on the latest code available in your branch 
> https://github.com/samhenri/kimchi.git. I have made changes in 
> "onRowSelected" method in kimchi.host.js.  Changes are highlighted below.
>
> Enable/disable button of each row was having same 'id' . Incorrect 
> action was displayed for the enabled repositories other than first 
> record as $('#repositories-grid-enable-button') was always returning 
> button from first action dropdown menu.
>
>
> onRowSelected: function(row) {
>                 var repository = repositoriesGrid.getSelected();
>                 if (!repository) {
>                     return;
>                 }
> *var selectedRow = $('tr', repositoriesGrid.bodyContainer);*
> $('#repositories-grid-remove-button',selectedRow).prop('disabled', false);
> $('#repositories-grid-edit-button',selectedRow).prop('disabled', false);
>                 var enabled = repository['enabled'];
>
> *$('#repositories-grid-enable-button',selectedRow)
>                     .html('<i class="fa 
> fa-play-circle-o"></i>'+*i18n[enabled ? 'KCHREPO6017M' : 'KCHREPO6016M'])
>                     .prop('disabled', false);
>             },
>
> Screenshots are attached herewith.
>
> Please ignore the mail if you have resolved the issue already .
>
> Thanks & Regards,
> Atreyee
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151015/ac828afb/attachment.html>