[Kimchi-devel] [PATCH 0/4] Fixes for Wok and Kimchi

[Aline Manera]

On 21/10/2015 09:39, Chandra Shehkhar Reddy Potula wrote:
>
>
> On 10/20/2015 02:40 AM, Aline Manera wrote:
>> Aline Manera (4):
>>    Remove any WOK error message from Kimchi
>>    Provide a meaningful message to WOKUTILS0001E
>>    Move validate_repo_url() and check_url_path() from Wok to Kimchi
> I guess we should keep validate_repo_url() and check_url_path() in the 
> wok self. Since Ginger base even uses these functions in repositories.py.
> My suggestion would be we should wait and watch while we are planning 
> to move such functionality.

This whole patch set is already applied upstream.

About gingerbase, the functions should be moved to there instead of 
being on wok or Kimchi.

>>    Use absolute import path
>>
>>   src/wok/control/tasks.py                       |  4 +-
>>   src/wok/i18n.py                                |  2 +-
>>   src/wok/plugins/kimchi/__init__.py             |  2 +-
>>   src/wok/plugins/kimchi/control/host.py         |  2 +-
>>   src/wok/plugins/kimchi/control/storagepools.py |  3 +-
>>   src/wok/plugins/kimchi/control/vms.py          |  2 +-
>>   src/wok/plugins/kimchi/distroloader.py         |  3 +-
>>   src/wok/plugins/kimchi/i18n.py                 |  1 +
>>   src/wok/plugins/kimchi/isoinfo.py              |  3 +-
>>   src/wok/plugins/kimchi/mockmodel.py            | 36 ++++++++--------
>>   src/wok/plugins/kimchi/model/config.py         | 22 +++++-----
>>   src/wok/plugins/kimchi/model/diskutils.py      |  3 +-
>>   src/wok/plugins/kimchi/model/host.py           |  6 +--
>>   src/wok/plugins/kimchi/model/hostdev.py        |  2 +-
>>   src/wok/plugins/kimchi/model/interfaces.py     |  2 +-
>>   src/wok/plugins/kimchi/model/model.py          |  2 +-
>>   src/wok/plugins/kimchi/model/storagepools.py   |  6 +--
>>   src/wok/plugins/kimchi/model/storageservers.py |  3 +-
>>   src/wok/plugins/kimchi/model/storagetargets.py |  4 +-
>>   src/wok/plugins/kimchi/model/storagevolumes.py |  5 ++-
>>   src/wok/plugins/kimchi/model/templates.py      |  2 +-
>>   src/wok/plugins/kimchi/model/vmhostdevs.py     |  8 ++--
>>   src/wok/plugins/kimchi/model/vmifaces.py       |  4 +-
>>   src/wok/plugins/kimchi/model/vms.py            | 13 +++---
>>   src/wok/plugins/kimchi/model/vmsnapshots.py    |  4 +-
>>   src/wok/plugins/kimchi/model/vmstorages.py     | 11 ++---
>>   src/wok/plugins/kimchi/repositories.py         |  9 ++--
>>   src/wok/plugins/kimchi/scan.py                 |  2 +-
>>   src/wok/plugins/kimchi/screenshot.py           |  2 +-
>>   src/wok/plugins/kimchi/swupdate.py             |  8 ++--
>>   src/wok/plugins/kimchi/tests/utils.py          |  7 ++-
>>   src/wok/plugins/kimchi/utils.py                | 60 
>> +++++++++++++++++++++++++-
>>   src/wok/plugins/kimchi/vmtemplate.py           | 21 +++++----
>>   src/wok/plugins/kimchi/xmlutils/disk.py        |  2 +-
>>   src/wok/utils.py                               | 55 
>> -----------------------
>>   35 files changed, 167 insertions(+), 154 deletions(-)
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>