[Kimchi-devel] [PATCH 0/2] Using existing VG as storage pool

[Aline Manera]

Hi Ziviani!

Thanks for sending out those patches!
I will rebase them on top of master to test and apply the comments I 
made. I will also add tests before sending the patches back for review.

I will ask Socorro to help me on UI.

Regards,
Aline Manera

On 22/10/2015 22:52, Jose Ricardo Ziviani wrote:
> Team, this work is not completed. I'm sending it to ML anyway because
> probably someone else will continue on it.
>
> What it has to be done:
>   - implement test;
>   - finish the frontend part:
>     - storage pool name textfield cannot be edited if user select a VG
>       (that vgname should populate the storage pool name automatically).
>     - fix any UI bug.
>     - create error messages accordingly (error codes used in frontend are
>       mockups);
>     - Add i18n for tmpl file.
>
> The backend looks ok but I made some quick tests during the development.
>
> I'll be reading my e-mails during the residency so I'm pretty sure we
> can work together.
>
> Thanks
>
> Jose Ricardo Ziviani (2):
>    Implement the backend to use existing VG as storage pool
>    Implement the frontend to use existing VG as storage pool
>
>   src/wok/plugins/kimchi/API.json                    |   5 +
>   src/wok/plugins/kimchi/control/host.py             |  22 ++++
>   src/wok/plugins/kimchi/disks.py                    | 123 +++++++++++++++++++++
>   src/wok/plugins/kimchi/i18n.py                     |   3 +
>   src/wok/plugins/kimchi/model/host.py               |  30 +++++
>   src/wok/plugins/kimchi/model/storagepools.py       |   7 +-
>   .../kimchi/ui/css/theme-default/storage.css        |  22 ++++
>   src/wok/plugins/kimchi/ui/js/src/kimchi.api.js     |  11 ++
>   .../ui/js/src/kimchi.storagepool_add_main.js       |  58 +++++++++-
>   .../kimchi/ui/pages/storagepool-add.html.tmpl      |  38 ++++++-
>   10 files changed, 313 insertions(+), 6 deletions(-)
>