[Kimchi-devel] [PATCH 4/5] [WOK] Updating Kimchi plugin with new-ui

[Lucio Correia]

On 09/10/2015 04:38 PM, Aline Manera wrote:
>
>
> On 25/08/2015 17:06, sguimaraes943 at gmail.com wrote:
>> From: samhenri <samuel.guimaraes at eldorado.org.br>
>>
>> Added some new-ui markup to Kimchi. Please note that some pages may
>> stop working since the new-ui is not finished yet.
>>
>> Signed-off-by: samhenri <samuel.guimaraes at eldorado.org.br>
>> ---
>>   plugins/kimchi/ui/config/tab-ext.xml
>
>>      |   7 +-
>>   plugins/kimchi/ui/css/theme-default/button.css |  72 +++++++--------
>
> This CSS file is applied for all the buttons in the application, right?
> If so it should be into wok instead of kimchi...
>
> All the widgets and style related should be on wok and only reuse in the
> plugins.
>
> So unless, Kimchi wants to change the default button style this file
> button.css should not exist on kimchi.
>
> Thinking on that direction the CSS should be changed to add 'wok' as CSS
> class prefix and moved to wok UI directory.
>
>>   plugins/kimchi/ui/images/logo.ico              | Bin 1214 -> 15086
>> bytes
>
>>   plugins/kimchi/ui/js/src/kimchi.grid.js        |  13 +--
>
> Same I commented above.
> It is related to the grid widget, so should be on wok.
>

Samuel, with recent merges into upstream branch wok, grid.css and 
button.css are now already in wok.

I've also split button.css into a generic part (in wok) and a small 
kimchi-specific part for which I created an icon.css in kimchi.


-- 
Lucio Correia
Software Engineer
IBM LTC Brazil