[Kimchi-devel] [PATCH V2] [Kimchi 0/4] Issue #817 - PCI attach/detach improvements.

[Daniel Henrique Barboza]

Code looks good, just a minor copyright fix in patch 1.

Also, I think this is the kind of work that requires some unit tests to 
ensure it'll
endure the trials of time.

On 04/14/2016 06:36 PM, pvital at linux.vnet.ibm.com wrote:
> From: Paulo Vital <pvital at linux.vnet.ibm.com>
>
> This is the backend part of the solution to Issue #817. In this solution the
> support for handle Libvirt events is added, as well, the attach and detach
> functions were modified to return AsyncTasks (then frontend can be informed
> when a device is really attached/detached).
>
> Patch "Add support to Libvirt Events." is the third version of previous
> submitted patch.
>
> Patch "Make detach device return an AsyncTask" needs submitted Wok patch
> "Update AsyncResource class with delete method." to work.
>
> Paulo Vital (4):
>    Add support to Libvirt Events.
>    Add Events support to VM's Devices attach/detach.
>    Make attach device return an AsyncTask
>    Make detach device return an AsyncTask
>
>   control/vm/hostdevs.py |   6 +--
>   i18n.py                |   4 ++
>   model/libvirtevents.py | 124 +++++++++++++++++++++++++++++++++++++++++++++
>   model/model.py         |   6 ++-
>   model/vmhostdevs.py    | 135 ++++++++++++++++++++++++++++++++++++++++++-------
>   5 files changed, 254 insertions(+), 21 deletions(-)
>   create mode 100644 model/libvirtevents.py
>
> --
> 2.5.5
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel