[Kimchi-devel] [PATCH] [Kimchi 1/4] Add support to Libvirt Events.

[Paulo Ricardo Paz Vital]

On Apr 18 08:59AM, Daniel Henrique Barboza wrote:
> 
> 
> On 04/18/2016 08:38 AM, Paulo Ricardo Paz Vital wrote:
> >Why 'make check-local' did not pointed this for me?
> 
> [danielhb at arthas kimchi]$ sudo make check-local
> (..)
> contrib/check_i18n.py ./i18n.py
> Checking for invalid i18n string...
> Checking for invalid i18n string successfully
> /bin/pep8 --version
> 1.6.2
> /bin/pep8 --filename '*.py,*.py.in'
> --exclude="*config.py,*i18n.py,*tests/test_config.py" .
> ./check_ui_code_errors.sh
> UI errors codes are correct
> Whitespace verification ...
> Ok
> IBM copyright year verification ...
> [danielhb at arthas kimchi]$ git diff
> diff --git a/model/libvirtevents.py b/model/libvirtevents.py
> index 86e012a..fdc269c 100644
> --- a/model/libvirtevents.py
> +++ b/model/libvirtevents.py
> @@ -1,7 +1,7 @@
>  #
>  # Project Kimchi
>  #
> -# Copyright IBM, Corp. 2016
> +# Copyright IBM Corp, 2016
>  #
>  # This library is free software; you can redistribute it and/or
>  # modify it under the terms of the GNU Lesser General Public
> [danielhb at arthas kimchi]$
> 
> 
> The script will point if there is a header missing in a file, but not if
> an existing header was fixed.

That's weird. My 'make check-local' said that the line was OK.
I sent a V3 with this fix.

> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
> 

-- 
Paulo Ricardo Paz Vital
Linux Technology Center, IBM Systems
http://www.ibm.com/linux/ltc/