[Kimchi-devel] [PATCH][Wok] wokd service not comes up after reboot when enabled

[Chandra Shekhar Reddy Potula]

On 04/02/16 5:52 PM, Daniel Henrique Barboza wrote:
>
>
> On 02/04/2016 09:58 AM, Aline Manera wrote:
>>
>>
>> On 02/04/2016 09:09 AM, chandra at linux.vnet.ibm.com wrote:
>>> From: Chandra Shekhar Reddy Potula <chandra at linux.vnet.ibm.com>
>>>
>>> Fixed Issue #31 : wokd service not comes up after reboot when enabled
>>> ---
>>>   contrib/wokd.service.fedora | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/contrib/wokd.service.fedora b/contrib/wokd.service.fedora
>>> index 33d88d8..68ae831 100644
>>> --- a/contrib/wokd.service.fedora
>>> +++ b/contrib/wokd.service.fedora
>>> @@ -1,5 +1,6 @@
>>>   [Unit]
>>>   Description=Wok - Webserver Originated from Kimchi
>>> +After=libvirtd.service
>>
>> Wok server does not depend on libvirtd service. It is a Kimchi 
>> dependency and properly reported on kimchid service config file.
>
> If Chandra patch fixes this issue by adding this libvirtd condition, 
> well, it means that we have
> a flaw in the design of the plug-in dependencies + wok running as a 
> service.
>
> Having the dependency in kimchid.service.fedora is of no avail if 
> wokd.service.fedora isn't aware
> of it. If there's no default way of making wokd aware of the 
> dependencies of kimchid.service and
> other dependencies of all the plug-ins, we'll need some sort of 
> initialization script or something.
>
I totally agree with Daniel.

I have not done extensive investigation but in reality some where we are 
referring libvirt part of wokd.service and that has to be corrected to 
make wokd service running with out a fail.

>>
>>>   [Service]
>>>   Type=simple
>>
>> _______________________________________________
>> Kimchi-devel mailing list
>> Kimchi-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>