[Kimchi-devel] [PATCH v2] [Kimchi 5/8] Import term.js to Kimchi project

[Aline Manera]

On 02/09/2016 04:23 PM, Jose Ricardo Ziviani wrote:
>   - term.js project (https://github.com/chjj/term.js) is a xterm clone
>     written in javascript and distributed under MIT license.
>
> Signed-off-by: Jose Ricardo Ziviani <joserz at linux.vnet.ibm.com>
> ---
>   ui/serial/term.js | 5973 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 5973 insertions(+)
>   create mode 100644 ui/serial/term.js
>
> diff --git a/ui/serial/term.js b/ui/serial/term.js
> new file mode 100644
> index 0000000..f542dd0
> --- /dev/null
> +++ b/ui/serial/term.js

It is good to have a dedicated directory for the imported code.
I noticed in the previous patch, you also added serial.html to /ui/serial

My suggestion is:

/ui/serial/serial/html

/ui/serial/libs/term.js

Please, also update the COPYING file to point to this imported code.

>