[Kimchi-devel] [PATCH v2][Kimchi 0/4] Support to edit max memory

Aline Manera alinefm at linux.vnet.ibm.com
Tue Feb 23 14:10:46 UTC 2016


Reviewed-by: Aline Manera <alinefm at linux.vnet.ibm.com>

On 02/21/2016 01:14 AM, Rodrigo Trujillo wrote:
> V2:
> - Includes fixes from reviews;
> - New validate_memory function to be used in Templates and Guests
>    creation/update processes;
> - Adds new function to update objectstore, to update 'memory'
>    from old to new schema.
>
>
> V1:
> This patchset implements the support in backend to allow user to
> change maxMemory xml tag.
> It also changes the memory API from 'memory: XXX' to
>     'memory': {'current': XXX, 'maxmemory': YYY}
>
> maxMemory xml tag is not created by default anymore, when a guest is
> created. Tag will be created only when the user changes maxmemory
> manually, and if the value is different (higher) of 'current' memory.
> So in order to performe memory hotplug, an user has to stop guest,
> modify maxmemory and then start the guest.
>
> Tests were fixed and new ones were included.
>
> Rodrigo Trujillo (4):
>    Add support to edit max memory in Templates
>    Add function to update 'memory' in objectstore
>    Add support to edit max memory in Guest
>    Changes and add tests to support new memory API (templates/guest)
>
>   API.json                    |  41 ++++----
>   docs/API.md                 |  29 ++++--
>   i18n.py                     |  12 ++-
>   model/templates.py          |  64 +++++++++++-
>   model/vms.py                | 245 ++++++++++++++++++++++++--------------------
>   osinfo.py                   |  16 ++-
>   root.py                     |   4 +
>   template.conf               |  10 +-
>   tests/test_livemigration.py |   6 +-
>   tests/test_model.py         |  22 ++--
>   tests/test_rest.py          |  23 ++++-
>   tests/test_template.py      |  38 +++++--
>   tests/test_vmtemplate.py    |  26 +++--
>   utils.py                    |  46 +++++++++
>   vmtemplate.py               |  75 ++++++--------
>   15 files changed, 428 insertions(+), 229 deletions(-)
>




More information about the Kimchi-devel mailing list