[Kimchi-devel] [PATCH] [Kimchi 1/9] Virt-Viewer launcher: docs and i18n changes

[Daniel Henrique Barboza]

On 07/07/2016 10:45 AM, Lucio Correia wrote:
> On 07-07-2016 09:57, dhbarboza82 at gmail.com wrote:
>> From: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
>>
>> This patch adds the documentation and i18n changes for
>> the new Virt-Viewer launcher API.
>>
>> URI: plugins/kimchi/vms/*:name*/virtviewerfile
>>
>> 'Retrieve the Virt-Viewer launcher file to connect to the
>> graphics of this virtual machine. Virtual machine must
>> be running.'
>>
>> Signed-off-by: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
>> ---
>>   docs/API.md | 6 ++++++
>>   i18n.py     | 2 ++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/docs/API.md b/docs/API.md
>> index 84ef7c9..78c0574 100644
>> --- a/docs/API.md
>> +++ b/docs/API.md
>> @@ -286,6 +286,12 @@ Represents a snapshot of the Virtual Machine's 
>> primary monitor.
>>   **URI:** /plugins/kimchi/vms/*:name*/snapshots/current
>>   * **GET**: Retrieve current snapshot information for the virtual 
>> machine.
>>
>> +### Sub-resource: Virt-Viewer File
>> +**URI:** /plugins/kimchi/vms/*:name*/virtviewerfile
>> +* **GET**: Retrieve the Virt-Viewer launcher file to connect to the
>> +           graphics of this virtual machine. Virtual machine must
>> +           be running.
>> +
>>   ### Collection: Templates
>>
>>   **URI:** /plugins/kimchi/templates
>> diff --git a/i18n.py b/i18n.py
>> index 08a3ac8..deb0f8c 100644
>> --- a/i18n.py
>> +++ b/i18n.py
>> @@ -131,6 +131,8 @@ messages = {
>>       "KCHVM0080E": _("Cannot update Maximum Memory when guest is 
>> running."),
>>       "KCHVM0081E": _("Impossible to create %(dir)s directory."),
>>       "KCHVM0082E": _("Either the guest %(name)s did not start to 
>> listen to the serial or it is not configured to use the serial 
>> console."),
>> +    "KCHVM0083E": _("Unable to retrieve virt viever file for stopped 
>> virtual machine %(name)s"),
> viever -> viewer
> capitalize is a good idea too -> Virt Viewer
>
>> +    "KCHVM0084E": _("Error occured while retrieving the virt viewer 
>> file for virtual machine %(name)s : %(err)s"),
> capitalize Virt Viewer

Will fix these in v2
>
>>
>>       "KCHVMHDEV0001E": _("VM %(vmid)s does not contain directly 
>> assigned host device %(dev_name)s."),
>>       "KCHVMHDEV0002E": _("The host device %(dev_name)s is not 
>> allowed to directly assign to VM."),
>>
>
>