[Kimchi-devel] [PATCH] [Kimchi 7/9] Virt-Viewer launcher: test changes for firewall manager

[dhbarboza82 at gmail.com]

From: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>

This patch adds unit tests for the FirewallManager class.

Signed-off-by: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
---
 tests/test_model.py | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/tests/test_model.py b/tests/test_model.py
index 2fc1d38..1162d2c 100644
--- a/tests/test_model.py
+++ b/tests/test_model.py
@@ -48,6 +48,7 @@ from wok.plugins.kimchi import osinfo
 from wok.plugins.kimchi.config import kimchiPaths as paths
 from wok.plugins.kimchi.model import model
 from wok.plugins.kimchi.model.libvirtconnection import LibvirtConnection
+from wok.plugins.kimchi.model.virtviewerfile import FirewallManager
 from wok.plugins.kimchi.model.virtviewerfile import VMVirtViewerFileModel
 from wok.plugins.kimchi.model.vms import VMModel
 
@@ -433,6 +434,76 @@ class ModelTests(unittest.TestCase):
         mock_get_graphics.assert_called_once_with('kimchi-vm', None)
         mock_vm_running.assert_called_once_with('kimchi-vm')
 
+    @mock.patch('wok.plugins.kimchi.model.virtviewerfile.run_command')
+    def test_firewall_provider_firewallcmd(self, mock_run_cmd):
+        mock_run_cmd.side_effect = [
+            ['', '', 0], ['', '', 0], ['', '', 0]
+        ]
+
+        fw_manager = FirewallManager()
+        fw_manager.add_vm_graphics_port('vm-name', 5905)
+        self.assertEqual(fw_manager.opened_ports, {'vm-name': 5905})
+
+        fw_manager.remove_vm_graphics_port('vm-name')
+        self.assertEqual(fw_manager.opened_ports, {})
+
+        mock_run_cmd.assert_has_calls(
+            [
+                 call(['firewall-cmd', '--state', '-q']),
+                 call(['firewall-cmd', '--add-port=5905/tcp']),
+                 call(['firewall-cmd', '--remove-port=5905/tcp'])
+            ]
+        )
+
+    @mock.patch('wok.plugins.kimchi.model.virtviewerfile.run_command')
+    def test_firewall_provider_ufw(self, mock_run_cmd):
+        mock_run_cmd.side_effect = [
+            ['', '', 1], ['', '', 0], ['', '', 0], ['', '', 0]
+        ]
+
+        fw_manager = FirewallManager()
+        fw_manager.add_vm_graphics_port('vm-name', 5905)
+        self.assertEqual(fw_manager.opened_ports, {'vm-name': 5905})
+
+        fw_manager.remove_vm_graphics_port('vm-name')
+        self.assertEqual(fw_manager.opened_ports, {})
+
+        mock_run_cmd.assert_has_calls(
+            [
+                 call(['firewall-cmd', '--state', '-q']),
+                 call(['ufw', 'status']),
+                 call(['ufw', 'allow', '5905/tcp']),
+                 call(['ufw', 'deny', '5905/tcp'])
+            ]
+        )
+
+    @mock.patch('wok.plugins.kimchi.model.virtviewerfile.run_command')
+    def test_firewall_provider_iptables(self, mock_run_cmd):
+        mock_run_cmd.side_effect = [
+            ['', '', 1], ['', '', 1], ['', '', 0], ['', '', 0]
+        ]
+
+        fw_manager = FirewallManager()
+        fw_manager.add_vm_graphics_port('vm-name', 5905)
+        self.assertEqual(fw_manager.opened_ports, {'vm-name': 5905})
+
+        fw_manager.remove_vm_graphics_port('vm-name')
+        self.assertEqual(fw_manager.opened_ports, {})
+
+        iptables_add = ['iptables', '-I', 'INPUT', '-p', 'tcp', '--dport',
+                        5905, '-j', 'ACCEPT']
+
+        iptables_del = ['iptables', '-D', 'INPUT', '-p', 'tcp', '--dport',
+                        5905, '-j', 'ACCEPT']
+
+        mock_run_cmd.assert_has_calls(
+            [
+                 call(['firewall-cmd', '--state', '-q']),
+                 call(['ufw', 'status']),
+                 call(iptables_add), call(iptables_del)
+            ]
+        )
+
     @unittest.skipUnless(utils.running_as_root(), "Must be run as root")
     def test_vm_serial(self):
         inst = model.Model(objstore_loc=self.tmp_store)
-- 
2.5.5