[Kimchi-devel] [PATCH v2][Kimchi 0/2] Issue #467: Feature: Show boot menu for a guest

Aline Manera alinefm at linux.vnet.ibm.com
Thu Jul 21 18:20:04 UTC 2016


Hi Ramon,

Sorry, I haven't seen there was a V2 before reviewing the first patch 
set version.

But I think all my comments apply to that version too.

Regards,
Aline Manera

On 07/21/2016 11:24 AM, Ramon Medeiros wrote:
> Changes:
>
> v2:
> fix import order
>
> Ramon Medeiros (2):
>    Issue #467: Feature: Show boot menu for a guest
>    Add test to verify bootmenu and update old tests
>
>   API.json                |  5 +++++
>   docs/API.md             |  1 +
>   i18n.py                 |  1 +
>   model/vms.py            | 30 +++++++++++++++++++++---------
>   tests/test_mockmodel.py |  2 +-
>   tests/test_model.py     |  8 +++++++-
>   xmlutils/bootorder.py   |  4 ++++
>   7 files changed, 40 insertions(+), 11 deletions(-)
>




More information about the Kimchi-devel mailing list