[Kimchi-devel] [PATCH v2] [Kimchi] Issue #956: Unable to assign pci passthrough devices through kimchi

[Aline Manera]

Almost there! =)

I noticed the following:

1. Tried to attach a device
2. Task was created but it failed

[alinefm at alinefm-TP440 wok]$ curl -H "Content-Type: application/json" -H 
"Accept: application/json" -k https://localhost:8001/plugins/kimchi/tasks/2
{
   "status":"failed",
   "message":"KCHVMHDEV0003E: No IOMMU groups found. Host PCI pass 
through needs IOMMU group to function correctly. Please enable Intel 
VT-d or AMD IOMMU in your BIOS, then verify the Kernel is compiled with 
IOMMU support. For Intel CPU, add 'intel_iommu=on' to GRUB_CMDLINE_LINUX 
parameter in /etc/default/grub file. For AMD CPU, add 'iommu=pt iommu=1'.",
   "id":"2",
   "target_uri":"/plugins/kimchi/vms/opensuse42.1/hostdevs/"
}[

3. I could see a request on 
/tasks?target_uri=status=running&target_uri=/plugins/kimchi/vms/*name*/hostdevs

The problem is the task status is failed. So it is running nothing and 
no error is shown.

On 07/21/2016 05:49 PM, sguimaraes943 at gmail.com wrote:
> From: Samuel Guimarães <sguimaraes943 at gmail.com>
>
> This commit fixes an issue with PCI passthrough devices through Kimchi.
> It also addresses an enhancement to display success messages when some actions doesn't require the Save button and there's no UI feedback to the user (Issue #975).
>
> v2 - Added error callbacks for kimchi.addVMPCIDevice() and kimchi.removeVMPCIDevice() to display error messages before if starts to track ongoing tasks.
>
> Samuel Guimarães (1):
>    Issue #956: Unable to assign pci passthrough devices through kimchi
>
>   model/vmhostdevs.py                  |   2 +-
>   ui/css/kimchi.css                    |   5 +
>   ui/css/src/modules/_edit-guests.scss |   4 +
>   ui/js/src/kimchi.guest_edit_main.js  | 236 +++++++++++++++++++++++------------
>   ui/js/src/kimchi.guest_main.js       |  10 +-
>   ui/pages/guest-edit.html.tmpl        |  20 ++-
>   ui/pages/i18n.json.tmpl              |   2 +
>   7 files changed, 180 insertions(+), 99 deletions(-)
>