[Kimchi-devel] [PATCH][Kimchi 0/5] Make Kimchi able to change guest's boot order

[Rodrigo Trujillo]

Patchset looks very good, I would like to propose a change only:

  * add the restriction of dev types in the JSON schema, then make 
messages more clear about them

I will comment in the patches, take a look.

Rodrigo

On 06/06/2016 08:50 PM, Ramon Medeiros wrote:
> How to use:
>
> curl -u root -H "Content-Type: application/json" -H "Accept: 
> application/json" -k http://localhost:8010/plugins/kimchi/vms/fedora 
> -X PUT -d '{"boot":{"order":["cdrom", "hd"]}}'
>
> Enter host password for user 'root':
> {
>   "users":[],
>   "screenshot":null,
>   "persistent":true,
>   "cpu_info":{
>     "maxvcpus":1,
>     "vcpus":1,
>     "topology":{}
>   },
>   "groups":[],
>   "graphics":{
>     "passwd":null,
>     "passwdValidTo":null,
>     "type":"vnc",
>     "port":null,
>     "listen":"127.0.0.1"
>   },
>   "icon":"plugins/kimchi/images/icon-fedora.png",
>   "stats":{
>     "cpu_utilization":0,
>     "io_throughput":0,
>     "io_throughput_peak":100,
>     "net_throughput":0,
>     "mem_utilization":0,
>     "net_throughput_peak":100
>   },
>   "name":"fedora",
>   "boot":[
>     "cdrom",
>     "hd"
>   ],
>   "uuid":"98a82c16-c6ae-4253-b018-08ab3fde8f5e",
>   "access":"full",
>   "state":"shutoff",
>   "memory":{
>     "current":1024,
>     "maxmemory":1024
>   }
> }
>
>
>
> On 06/06/2016 06:13 PM, Ramon Medeiros wrote:
>> Ramon Medeiros (5):
>>    Create method to change bootorder of a guest
>>    Update documentation about bootorder on vm update
>>    Update REST API
>>    Add function to retrieve bootorder on vm lookup
>>    Add test to check bootorder
>>
>>   API.json            | 12 ++++++++++++
>>   docs/API.md         |  2 ++
>>   i18n.py             |  2 ++
>>   model/vms.py        | 41 +++++++++++++++++++++++++++++++++++++++--
>>   tests/test_model.py |  5 +++++
>>   5 files changed, 60 insertions(+), 2 deletions(-)
>>
>