[Kimchi-devel] [PATCH] [Wok] Issue #79: All error messages should keep on UI until user dismiss it

[Samuel Henrique De Oliveira Guimaraes]

Hi Socorro, I think this is happening because I've added a new parameter to wok.message but not for wok.message.error or wok.message.warn. I'll take a look and maybe send a v2 for this or send new patches for Kimchi.

-----Original Message-----
From: kimchi-devel-bounces at ovirt.org [mailto:kimchi-devel-bounces at ovirt.org] On Behalf Of Socorro Stoppler
Sent: quarta-feira, 22 de junho de 2016 20:41
To: sguimaraes943 at gmail.com; Kimchi Devel <kimchi-devel at ovirt.org>
Subject: Re: [Kimchi-devel] [PATCH] [Wok] Issue #79: All error messages should keep on UI until user dismiss it

Hi Samuel,

I noticed the following in Kimchi after applying your patch with some of the scenarios I ran:

Click on Add a Storage, enter any invalid info and click on Create button:
     Error shows on parent panel, not main panel although the error does not disappear on its own which is the intent.
     I think we've encountered this problem before where the error shows on parent panel instead of main panel.

Click on Add Template, enter any path in File Path, click on Create button:
     Error shows on main panel, but no X (and it doesn't disappear either which is the intent)

In both cases, prior to your patch the error messages would disappear after a few seconds and with your patch now the messages stay until user closes them so that part seems to work.

Thanks
-Socorro

On 06/22/2016 08:45 AM, sguimaraes943 at gmail.com wrote:
> From: Samuel Guimarães <sguimaraes943 at gmail.com>
>
> This commit makes all messages closeable by default, removing the fade animation after 10 seconds.
> A parameter to allow a custom ID for each alert was also added to wok.message function.
>
> Samuel Guimarães (1):
>    Issue #79: All error messages should keep on UI until user dismiss 
> it
>
>   ui/js/src/wok.message.js | 53 +++++++++++++++++++++++++-----------------------
>   1 file changed, 28 insertions(+), 25 deletions(-)
>

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel