[Kimchi-devel] [PATCH] [Wok] Adds DataTables.net plugin and Moment.js to Wok

[Samuel Henrique De Oliveira Guimaraes]

Hi, now that I noticed, the JS files were not included because they are named .min.js and ignored by .gitignore. I'll send a v2.

Samuel 

-----Original Message-----
From: kimchi-devel-bounces at ovirt.org [mailto:kimchi-devel-bounces at ovirt.org] On Behalf Of Aline Manera
Sent: segunda-feira, 27 de junho de 2016 15:54
To: sguimaraes943 at gmail.com; Kimchi Devel <kimchi-devel at ovirt.org>
Subject: Re: [Kimchi-devel] [PATCH] [Wok] Adds DataTables.net plugin and Moment.js to Wok



On 06/24/2016 05:57 PM, sguimaraes943 at gmail.com wrote:
> From: Samuel Guimarães <sguimaraes943 at gmail.com>
>
> This commit adds DataTables.net jQuery plugin and Moment.js library to Wok.
>
> DataTables.net is a table plugin that supports pagination, instance search and multi-column ordering. It also has a responsive module and it is compatible with many different CSS libraries.
> In this commit it is included a customization for its Bootstrap integration and a default initialization script pre-loaded with Wok styles.
>
> Moment.js is a lightweight JavaScript date library for parsing, validating, manipulating, and formatting dates. It is required in order to filter and sort dates properly in Wok User Logs and Ginger Configuration Backup.
>
> Signed-off-by: Samuel Guimarães <sguimaraes943 at gmail.com>
> ---
>   configure.ac                         |   3 +
>   ui/css/Makefile.am                   |   8 +-
>   ui/css/datatables.bootstrap.css      | 243 +++++++++++++++++++++++++++++
>   ui/css/src/datatables.bootstrap.scss | 289 +++++++++++++++++++++++++++++++++++
>   ui/js/src/wok.datatables.js          |  26 ++++
>   ui/libs/Makefile.am

>                  |   2 +-
>   ui/libs/datatables/Makefile.am       |  23 +++
>   ui/libs/datatables/css/Makefile.am   |  21 +++
>   ui/libs/moment/LICENSE               |  22 +++
>   ui/libs/moment/Makefile.am           |  21 +++

Why are you creating empty directories? Is it indeed or you forgot to add the files to this patch?

>   ui/pages/login.html.tmpl             |   5 +
>   ui/pages/wok-ui.html.tmpl            |   5 +
>   12 files changed, 665 insertions(+), 3 deletions(-)
>   create mode 100644 ui/css/datatables.bootstrap.css
>   create mode 100644 ui/css/src/datatables.bootstrap.scss
>   create mode 100644 ui/js/src/wok.datatables.js
>   create mode 100644 ui/libs/datatables/Makefile.am
>   create mode 100644 ui/libs/datatables/css/Makefile.am
>   create mode 100644 ui/libs/moment/LICENSE
>   create mode 100644 ui/libs/moment/Makefile.am
>

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel