[Kimchi-devel] [PATCH] [Kimchi] Fixed Memory and Max Memory values when adding a new Guest

[Samuel Henrique De Oliveira Guimaraes]

Hi. I think the Templates should be updated to look like Guests, including the Max Memory and Max CPU labels.

Samuel

From: kimchi-devel-bounces at ovirt.org [mailto:kimchi-devel-bounces at ovirt.org] On Behalf Of Socorro Stoppler
Sent: quarta-feira, 9 de março de 2016 20:49
To: sguimaraes943 at gmail.com; Kimchi Devel <kimchi-devel at ovirt.org>
Subject: Re: [Kimchi-devel] [PATCH] [Kimchi] Fixed Memory and Max Memory values when adding a new Guest

Regarding my question below about CPUs, should it look like this?

(From adding a guest)

[cid:image001.png at 01D17B7C.4B5492D0]

A couple more observations:
1.  Above has the units displayed without a space to the right of the #.  But in Templates tab (regardless of the view), it has a space as such below.
Shouldn't they be consistent?

2.  Does it make sense here to show the max for CPU and Memory for Templates?

(Gallery view of Templates)

[cid:image002.png at 01D17B7C.4B5492D0]

Thanks
-Socorro
On 03/09/2016 02:24 PM, Socorro Stoppler wrote:
Reviewed-by: Socorro Stoppler <socorro at linux.vnet.ibm.com><mailto:socorro at linux.vnet.ibm.com>
Tested-by: Socorro Stoppler <socorro at linux.vnet.ibm.com><mailto:socorro at linux.vnet.ibm.com>

Question:  should CPU be also shown the same way?

On 03/09/2016 01:55 PM, sguimaraes943 at gmail.com<mailto:sguimaraes943 at gmail.com> wrote:

From: Samuel Guimarães <sguimaraes943 at gmail.com><mailto:sguimaraes943 at gmail.com>

Signed-off-by: Samuel Guimarães <sguimaraes943 at gmail.com><mailto:sguimaraes943 at gmail.com>
---
  ui/pages/guest-add.html.tmpl | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/ui/pages/guest-add.html.tmpl b/ui/pages/guest-add.html.tmpl
index a531af2..57f187e 100644
--- a/ui/pages/guest-add.html.tmpl
+++ b/ui/pages/guest-add.html.tmpl
@@ -59,13 +59,15 @@
                                                      <h3 class="iso-title {os_distro}" title="{name}">{name}</h3>
                                                          <dl class="iso-info">
                                                              <dt>{os_distro}</dt>
-                                                            <dd>$_("OS: ")</dd>
+                                                            <dd>$_("OS")</dd>
                                                              <dt>{os_version}</dt>
-                                                            <dd>$_("Version: ")</dd>
+                                                            <dd>$_("Version")</dd>
                                                              <dt>{cpus}</dt>
                                                              <dd>$_("CPUS")</dd>
-                                                            <dt>{memory}M</dt>
+                                                            <dt>{memory.current}M</dt>
                                                              <dd>$_("Memory")</dd>
+                                                            <dt>{memory.maxmemory}M</dt>
+                                                            <dd>$_("Max Memory")</dd>
                                                          </dl>
                                                  </span>
                                              </span>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20160311/a66843c1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 19874 bytes
Desc: image001.png
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20160311/a66843c1/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 18954 bytes
Desc: image002.png
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20160311/a66843c1/attachment-0001.png>