[Kimchi-devel] Gap between the scss/css file's

[Samuel Henrique De Oliveira Guimaraes]

Hi team,

Sometimes when we change the SCSS files the CSS output will be exactly the same. I can't recall exactly when, but there were some occasions that I had to reorganize the SCSS files or remove a static color or font variable and then replaced it with a variable in _wok-variables.scss. 
There's also the possibility that python-libsass is running different versions from distro to distro and generating different selectors, although this won't change anything in the CSS except for readability. For example:

#guest-edit-window #form-guest-edit-general #guest-edit-memory-textbox,
#guest-edit-window #form-guest-edit-general #guest-show-max-memory,
#guest-edit-window #form-guest-edit-general #guest-edit-cores-textbox,
#guest-edit-window #form-guest-edit-general #guest-show-max-processor {
  display: inline-block;
}

Sometimes is generated like this:

#guest-edit-window #form-guest-edit-general #guest-edit-memory-textbox, #guest-edit-window #form-guest-edit-general #guest-show-max-memory, #guest-edit-window #form-guest-edit-general #guest-edit-cores-textbox, #guest-edit-window #form-guest-edit-general #guest-show-max-processor {
  display: inline-block;
}

I suggest we look for updates in Libsass (pip install --upgrade libsass) before running any major change in the CSS files to avoid this.

Regards,
Samuel

-----Original Message-----
From: kimchi-devel-bounces at ovirt.org [mailto:kimchi-devel-bounces at ovirt.org] On Behalf Of Aline Manera
Sent: sexta-feira, 18 de março de 2016 10:59
To: Chandra Shekhar Reddy Potula <chandra at linux.vnet.ibm.com>; ginger-dev-list at googlegroups.com; kimchi-devel at ovirt.org
Subject: Re: [Kimchi-devel] Gap between the scss/css file's


Hi Chandra,

Yeap! While doing UI development, the developer needs to make sure the CSS file is updated according to changes on SCSS.

There is a guide at
https://github.com/kimchi-project/wok/wiki/How-to-Contribute#ui-development
for more details.

Today, I don't see any gap between CSS and SCSS on upstream branches for Kimchi and Wok so we don't need to take any action on that.

Regards,
Aline Manera

On 03/18/2016 08:20 AM, Chandra Shekhar Reddy Potula wrote:
> Hi All,
>
> I see a gap between scss and css always in the upstream code. For sure 
> during the development we always re-compile and get the latest style 
> sheets.
>
> My suggestion would be whenever there is a change in the scss file's 
> request to upstream, will it be good idea to ask developer who want 
> scss changes to upstream push corresponding css file changes too ie 
> re-compiled code ?
>
> This will some times eliminate the gap between the css and scss files, 
> which I suppose mostly taken care by the maintainer at present ?
>
> Just a thought, let me know your views on this !!!
>
>
> Thanks and Regards
> Chandra
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel