[Kimchi-devel] [PATCH][Kimchi 1/4] Create a single field to pass the installation media

[Paulo Ricardo Paz Vital]

On Mar 29 04:27PM, Ramon Medeiros wrote:
> Signed-off-by: Ramon Medeiros <ramonn at linux.vnet.ibm.com>
> ---
>  API.json | 5 +++++
>  i18n.py  | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/API.json b/API.json
> index 6f0b484..ce25fe1 100644
> --- a/API.json
> +++ b/API.json
> @@ -468,6 +468,11 @@
>                      "error": "KCHTMPL0011E"
>                  },
>                  "memory": { "$ref": "#/kimchitype/memory" },
> +                "source_media": {
> +                    "description": "Path for installation media (ISO, disk, remote ISO)",
> +                    "type" : "string",
> +                    "pattern" : "^[^ ]+( +[^ ]+)*$"
> +                },
>                  "cdrom": {
>                      "description": "Path for cdrom",
>                      "type": "string",
> diff --git a/i18n.py b/i18n.py
> index 6214687..053604a 100644
> --- a/i18n.py
> +++ b/i18n.py
> @@ -168,7 +168,7 @@ messages = {
>      "KCHTMPL0013E": _("Amount of memory and maximum memory (MB) must be an integer greater than 512"),
>      "KCHTMPL0014E": _("Template CDROM must be a local or remote ISO file"),
>      "KCHTMPL0015E": _("Invalid storage pool URI %(value)s specified for template"),
> -    "KCHTMPL0016E": _("Specify an ISO image as CDROM or a base image to create a template"),
> +    "KCHTMPL0016E": _("Specify an argument to 'source_media' to create a template"),

Looking better the description above and the text of this message, I think you 
can re-write it to something more informative to user, like:

"Specify a path to source media (ISO, disk, remote ISO) to create a template"

>      "KCHTMPL0017E": _("All networks for the template must be specified in a list."),
>      "KCHTMPL0018E": _("Specify a volume to a template when storage pool is iSCSI or SCSI"),
>      "KCHTMPL0019E": _("The volume %(volume)s is not in storage pool %(pool)s"),
> -- 
> 2.5.5
> 
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
> 

-- 
Paulo Ricardo Paz Vital
IBM Linux Technology Center
http://www.ibm.com