[Kimchi-devel] [PATCH V2] [Kimchi 0/3] Issue #201: Handling libvirt connection failures.

[Aline Manera]

Hi Paulo,

'make check-local' is failing with this patch set:

[alinefm at alinefm-TP440 kimchi]$ sudo make check-local
[sudo] password for alinefm:
contrib/check_i18n.py ./i18n.py
Checking for invalid i18n string...
Checking for invalid i18n string successfully
./model/libvirtconnection.py:20: 'cherrypy' imported but unused
Makefile:1062: recipe for target 'check-local' failed
make: *** [check-local] Error 1

As it is simple I will fix before applying upstream.
Please, next time, make sure to run 'make check-local' and 'make check' 
before submitting a patch.

Regards,
Aline Manera

On 05/12/2016 06:32 PM, pvital at linux.vnet.ibm.com wrote:
> From: Paulo Vital <pvital at linux.vnet.ibm.com>
>
> V1 -> V2:
>      * Adapted to use the latest notifications changes from Wok
>      * Aesthetic changes
>
> V1:
> This is the backend part of the solution to solve issue #201. Frontend still
> needs some updates to provide more information to user.
>
> Paulo Vital (3):
>    Update Kimchi config file for Systemd service
>    Make Cheerypy up if not able to connect to libvirt
>    Add support to check if libvirtd is running.
>
>   contrib/kimchid.service.fedora |  3 ++-
>   contrib/kimchid.service.ubuntu |  3 ++-
>   i18n.py                        |  3 +++
>   model/config.py                | 17 +++++++++++++++--
>   model/libvirtconnection.py     | 13 +++++++++++--
>   model/templates.py             |  5 ++++-
>   utils.py                       | 16 +++++++++++++++-
>   7 files changed, 52 insertions(+), 8 deletions(-)
>
> --
> 2.5.5